doc: i2p documentation updates#27937
Merged
fanquake merged 2 commits intobitcoin:masterfrom Jun 30, 2023
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
jarolrod
reviewed
Jun 24, 2023
Contributor
jarolrod
left a comment
jarolrod
left a comment
There was a problem hiding this comment.
Concept ACK
Just finished going through setting this up with core on a clean ubuntu install. The changes here are nice cleanups for the documentation, which is important to get people up and running with these alternative networks.
The SAM application bridge is not enabled by default in the Java I2P Router, and the relevant info is somewhat difficult to find in its documentation. Also, remove a duplicate sentence; the preceding paragraph begins with the same.
- the Java I2P router and i2pd are the two routers have been heavily tested with Bitcoin Core and are what people and node software packages use - i2p-zero (https://github.com/i2p-zero/i2p-zero) hasn't been updated since July 2021 and its last release was in December 2020 - the other routers in the wikipedia page are niche
jonatack
force-pushed
the
2023-06-clarify-SAM-bridge-instructions-in-i2p-doc
branch
from
3a5b2c4 to
11900e5
Compare
fanquake
approved these changes
Jun 30, 2023
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 30, 2023
PastaPastaPasta
pushed a commit
to kwvg/dash
that referenced
this pull request
May 29, 2024
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
May 29, 2024
, bitcoin#26065, bitcoin#26837, bitcoin#25993, bitcoin#26838, bitcoin#27937, partial bitcoin#22589, bitcoin#22229 (i2p support: part 2) 0a23820 merge bitcoin#27937: i2p documentation updates (Kittywhiskers Van Gogh) 1dc50d0 merge bitcoin#26838: I2P documentation updates (Kittywhiskers Van Gogh) 5058519 merge bitcoin#25993: Add I2P guidance related to bandwidth and i2pd software version (Kittywhiskers Van Gogh) 859f59b merge bitcoin#26837: I2P network optimizations (Kittywhiskers Van Gogh) 9f80734 merge bitcoin#26065: use the same destination type for transient and persistent addresses (Kittywhiskers Van Gogh) 9bf3829 merge bitcoin#25355: add support for transient addresses for outbound connections (Kittywhiskers Van Gogh) 4977073 merge bitcoin#22497: remove ResetI2PPorts() (Kittywhiskers Van Gogh) 63d5853 merge bitcoin#22648: improve i2p/tor docs and i2p reachable unit tests (Kittywhiskers Van Gogh) f04ce8b partial bitcoin#22229: consolidate to f-strings (part 1) (Kittywhiskers Van Gogh) 68ea6cc merge bitcoin#22589: update I2P hardcoded seeds and docs for 22.0 (Kittywhiskers Van Gogh) Pull request description: ## Additional Information * Dependent on #6034 ## Breaking Changes * With I2P connections, a new, transient address is used for each outbound connection if `-i2pacceptincoming=0`. ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)** - [x] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: re-utACK [0a23820](0a23820); only changed commit title / text Tree-SHA512: ef426263d7e81a5eec8555db21dcd24f5dbb65f5faa7013c7e0601a4c60ae675813aadf68ebc19936aa15bdbd8f6db88b4bd55dfaf4ac412abbda86fb1ac9c83
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify when and how to launch the SAM application bridge to address user questions and I2P: Creating SAM session with 127.0.0.1:7656 #22759 (comment). The bridge is not enabled by default in the Java I2P Router, and the relevant info is somewhat difficult to find in its documentation.
Remove a duplicate sentence and link (the preceding paragraph begins with the same sentence and link).
Simplify the router options:
the Java I2P router and i2pd are the two routers have been heavily tested with Bitcoin Core and are what node operators and node software packages are using
i2p-zero hasn't been updated since July 2021 and its last release was in December 2020
the other routers in the wikipedia page are niche and I haven't heard anyone report using them