test, rpc: invalid sighashtype coverage#28166
Merged
fanquake merged 3 commits intobitcoin:masterfrom Aug 1, 2023
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
jonatack
force-pushed
the
2023-07-invalid-sighashtype-test-coverage
branch
from
f27f460 to
9dde725
Compare
maflcko
approved these changes
Jul 27, 2023
Member
maflcko
left a comment
maflcko
left a comment
There was a problem hiding this comment.
nit: I think it is fine to squash all the sighhashtype commits into one. They all do the same thing, and splitting it just makes review work harder, because at a minimum for each commit there is additional overhead for reviewers to check that a commit doesn't add a backdoor and removes it in the next commit.
in RPCs descriptorprocesspbst, walletprocesspbst, signrawtransactionwithkey, and signrawtransactionwithwallet.
as they are parsed identically. See AmountFromValue() / ParseFixedPoint() / UniValue#getValStr()
jonatack
force-pushed
the
2023-07-invalid-sighashtype-test-coverage
branch
from
9dde725 to
90c8f79
Compare
Member
Author
|
Thanks @MarcoFalke, done. |
maflcko
reviewed
Jul 27, 2023
Member
maflcko
left a comment
maflcko
left a comment
There was a problem hiding this comment.
lgtm ACK 90c8f79 🎥
Show signature
Signature:
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: lgtm ACK 90c8f79e945863f3818748b86572948d1558aec3 🎥
4nQVxrCzq3s4J1Z4BUrM5/b3iTRnVbJgJm6YkPfqhKZXEU7aCffkfhrz97XrUTitu/61d3dFQ202n8xosxSfBQ==
brunoerg
reviewed
Jul 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test coverage for passing an invalid sighashtype to RPCs signrawtransactionwithwallet, signrawtransactionwithkey, walletprocesspsbt, and descriptorprocesspsbt.