test: locked_wallet, skip default fee estimation#28232
Merged
fanquake merged 1 commit intobitcoin:masterfrom Aug 14, 2023
Merged
test: locked_wallet, skip default fee estimation#28232fanquake merged 1 commit intobitcoin:masterfrom
fanquake merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
|
concept ACK |
maflcko
approved these changes
Aug 7, 2023
theStack
reviewed
Aug 10, 2023
Same as we do with the nodes default wallets. No test case on this file is meant to exercise fee estimation.
furszy
force-pushed
the
2023_test_locked_wallet_hardcode_fee
branch
from
86aa6ca to
5364dd8
Compare
Member
Author
|
Updated per feedback. Thanks theStack. Tiny change. Instead of calculating the fee manually, the code now uses |
theStack
approved these changes
Aug 10, 2023
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 15, 2023
5364dd8 test: locked_wallet, skip default fee estimation (furszy) Pull request description: Coming from bitcoin#28139 (comment). No test case in this file is meant to exercise fee estimation. All default wallets have a custom tx fee set [here](https://github.com/bitcoin/bitcoin/blob/b7138252ace6d21476964774e094ed1143cd7a1c/test/functional/wallet_fundrawtransaction.py#L100). The only one missing is the one created for `locked_wallet`. ACKs for top commit: theStack: ACK 5364dd8 Tree-SHA512: 514c02708081d18330d759d10e306cee16c6350de243c68f0973777d2582f5d81968a237393c1f59aba245297e03f3f98d3ae5249a042469d0d016255f568719
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coming from #28139 (comment).
No test case in this file is meant to exercise fee estimation. All default wallets have a
custom tx fee set here. The only one missing is the one created for
locked_wallet.