Skip to content

BIP 32 derivation + test vectors#2829

Merged
gavinandresen merged 4 commits intobitcoin:masterfrom
sipa:bip32
Aug 15, 2013
Merged

BIP 32 derivation + test vectors#2829
gavinandresen merged 4 commits intobitcoin:masterfrom
sipa:bip32

Conversation

@sipa
Copy link
Member

@sipa sipa commented Jul 14, 2013

This does not add actual deterministic wallet functionality yet, only an implementation of BIP32 derivation and its test vectors.

I'm usually not in favor of adding code that isn't used yet, but in this case it may be useful to give a "reference implementation" exposure.

@BitcoinPullTester
Copy link

BitcoinPullTester commented Jul 18, 2013

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/a59db19ee3b454680b3bb0aa881e601b9311a9ae for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@simondlr
Copy link
Contributor

simondlr commented Jul 27, 2013

Do you plan on eventually implementing full BIP 32 support into Bitcoin-QT?

@sipa
Copy link
Member Author

sipa commented Jul 27, 2013

@simondlr Of course.

@simondlr
Copy link
Contributor

simondlr commented Jul 27, 2013

@sipa Awesome! Looking forward to it.

@sipa
Copy link
Member Author

sipa commented Aug 15, 2013

@gavinandresen @jgarzik @gmaxwell Opinions?

@gmaxwell
Copy link
Contributor

gmaxwell commented Aug 15, 2013

ACK. On the basis that this has already been used to validate other implementations and has even turned up some bugs, I think it would be good to include this.

@jgarzik
Copy link
Contributor

jgarzik commented Aug 15, 2013

ACK

gavinandresen added a commit that referenced this pull request Aug 15, 2013
@gavinandresen
Merge pull request #2829 from sipa/bip32
13d3b1c 
BIP 32 derivation + test vectors
@gavinandresen gavinandresen merged commit 13d3b1c into bitcoin:master Aug 15, 2013
@laanwj laanwj mentioned this pull request Nov 14, 2013
Closed
Bushstar pushed a commit to Bushstar/omnicore that referenced this pull request Apr 5, 2019
@UdjinM6 @codablock
Re-introduce nInstantSendKeepLock check for LLMQ-based IS when spork1…
208406d 
…9 is OFF (bitcoin#2829)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sipa @BitcoinPullTester @simondlr @gmaxwell @jgarzik @mikehearn @gavinandresen