ci: Use concurrency for pull requests only#28322
Merged
fanquake merged 1 commit intobitcoin:masterfrom Aug 24, 2023
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
hebasto
force-pushed
the
230822-concurr
branch
from
91e1334 to
41029aa
Compare
Otherwise, any previously pending workflow will be canceled on the following push.
hebasto
force-pushed
the
230822-concurr
branch
from
41029aa to
e7d67ef
Compare
maflcko
reviewed
Aug 22, 2023
Member
|
review only ACK e7d67ef |
real-or-random
added a commit
to bitcoin-core/secp256k1
that referenced
this pull request
Aug 23, 2023
ee1be62 ci: Use concurrency for pull requests only (Hennadii Stepanov) Pull request description: This PR is an amendment for #1403. It avoids skipping builds when some pushes were done consequentially. From GitHub Actions [docs](https://docs.github.com/en/actions/using-jobs/using-concurrency): > When a concurrent ... workflow is queued, if another ... workflow using the same concurrency group in the repository is in progress, the queued ... workflow will be pending. **Any previously pending ... workflow in the concurrency group will be canceled.** No behavior change for pull requests. Same as bitcoin/bitcoin#28322. ACKs for top commit: real-or-random: ACK ee1be62 Tree-SHA512: ce26378c3224a7647eb3b351d19e9308650ad49b933a68d37a0eca8516767a63f55580a33b02864caa539392c9aab0b4b54ecbace85bea6082bf533539a37c9c
dergoegge
approved these changes
Aug 23, 2023
Member
Author
|
Anything else I need to do here? |
Member
Author
|
It works as expected. No job skipped:
|
Frank-GER
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 8, 2023
e7d67ef ci: Use concurrency for pull requests only (Hennadii Stepanov) Pull request description: This PR is an amendment for bitcoin#28282. It avoids skipping builds when some pushes were done consequentially:  From GitHub Actions [docs](https://docs.github.com/en/actions/using-jobs/using-concurrency): > When a concurrent ... workflow is queued, if another ... workflow using the same concurrency group in the repository is in progress, the queued ... workflow will be pending. **Any previously pending ... workflow in the concurrency group will be canceled.** No behavior change for pull requests:  ACKs for top commit: MarcoFalke: review only ACK e7d67ef dergoegge: lgtm ACK e7d67ef Tree-SHA512: 360be9dbb46354d988935643e8793ea630c3416609c45aab4c39075a00a427487446a34a4fb93b490ece43cabe43640fcc6fb2ac97760e2c6ee54b95241da826
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an amendment for #28282.
It avoids skipping builds when some pushes were done consequentially:
From GitHub Actions docs:
No behavior change for pull requests: