build: Bump g++ minimum supported version to 10 by maflcko · Pull Request #28348 · bitcoin/bitcoin

maflcko · 2023-08-27T07:59:34Z

All supported operating systems ship with g++ 10 (or later), so bumping the minimum should not cause any issues. The bump allows to drop some now-unused workarounds.

For reference:

https://packages.debian.org/bullseye/g++ (g++-10)
https://packages.ubuntu.com/focal/g++-10
FreeBSD 12/13 ships with g++ 12
CentOS-like 9 ships with g++ 11
OpenSuse Tumbleweed ships with g++ 13 https://software.opensuse.org/package/gcc13-c++ (No idea about OpenSuse Leap)

This is for Bitcoin Core 27.0 in 2024 (next year), not the soon upcoming 26.0 next month.

DrahtBot · 2023-08-27T07:59:36Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#25972 (build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is set by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

fanquake · 2023-09-12T13:18:22Z

Concept ACK

DrahtBot · 2023-10-24T23:33:33Z

Guix builds (on x86_64)

File	commit `4370482` (master)	commit 664281c946d49e7f73a86f6e83bc270441841587 (master and this pull)
SHA256SUMS.part	`183387813ca7437c...`	`808258243827859b...`
*-aarch64-linux-gnu-debug.tar.gz	`dbe14eca3b7590f9...`	`241bd7d84a7f5d8d...`
*-aarch64-linux-gnu.tar.gz	`86e581c5aa6288be...`	`cbfa429f35141d8d...`
*-arm-linux-gnueabihf-debug.tar.gz	`1be1acedf78a3446...`	`e28c3f86d14feff1...`
*-arm-linux-gnueabihf.tar.gz	`09c5d6abefb45f51...`	`c7ad4ef02e34a1f4...`
*-arm64-apple-darwin-unsigned.tar.gz	`f6d41940fd261af9...`	`aa67b4ff1abafd37...`
*-arm64-apple-darwin-unsigned.zip	`268791efe0de4e07...`	`f5232a789018afe8...`
*-arm64-apple-darwin.tar.gz	`b6dadb8374975f5f...`	`48f40dbe38223dee...`
*-powerpc64-linux-gnu-debug.tar.gz	`ebe3060f3de9d6d0...`	`e756dd0f3ab2ca38...`
*-powerpc64-linux-gnu.tar.gz	`e6eac3cef68d41a6...`	`15470f515e536f52...`
*-powerpc64le-linux-gnu-debug.tar.gz	`4ffd1440c7990acb...`	`b3e1586b958616ed...`
*-powerpc64le-linux-gnu.tar.gz	`0b6bcd94d3c4b455...`	`9ba5162059a85d77...`
*-riscv64-linux-gnu-debug.tar.gz	`36928faea0e41f47...`	`6864140d3fdb1622...`
*-riscv64-linux-gnu.tar.gz	`53e7196be616f7fa...`	`caa6a221deea31b5...`
*-x86_64-apple-darwin-unsigned.tar.gz	`b51b362bd8e1f7bf...`	`0d3928be62095a6e...`
*-x86_64-apple-darwin-unsigned.zip	`a96fe067ca443670...`	`2ef9d1135fad680a...`
*-x86_64-apple-darwin.tar.gz	`062eb82c207dbebb...`	`8134e99679df61cd...`
*-x86_64-linux-gnu-debug.tar.gz	`934752412e800e61...`	`cc5d6ed14a40a95d...`
*-x86_64-linux-gnu.tar.gz	`23e28d2b322eeaf4...`	`1a2a5b45345a878d...`
*.tar.gz	`c49c626683702ab1...`	`7020911009382348...`
guix_build.log	`be39534ef95fdc39...`	`fbe1dc4a266efef3...`
guix_build.log.diff		`fce2dabbdcc37bbc...`

configure.ac

Also, enable -Werror=maybe-uninitialized in ci/test/00_setup_env_native_qt5.sh

fanquake

ACK fa5423b

fa6e50d fuzz: Use C++20 starts_with in rpc.cpp (MarcoFalke) faa4838 Revert "tracepoints: Disables `-Wgnu-zero-variadic-macro-arguments` to compile without warnings" (MarcoFalke) fae3b77 refactor: Drop unused _Pragma to ignore -Wgnu-zero-variadic-macro-arguments (MarcoFalke) fa02fc0 refactor: modernize-use-default-member-init for bit-fields (C++20) (MarcoFalke) fa67f09 build: Require C++20 compiler (MarcoFalke) Pull request description: C++20 allows to write safer code, because it allows to enforce more stuff at compile time (`constinit`, `conteval`, `constexpr`, `std::span`, ...). Also, it allows to write less verbose and easier to understand code (C++ 20 Concepts). See bitcoin/bitcoin#23363 and https://en.cppreference.com/w/cpp/compiler_support#cpp20 With g++-10 (bitcoin/bitcoin#28348) and clang-13 (bitcoin/bitcoin#28210), there is broad support for almost all features of C++20. It should be fine to require a C++20 compiler for Bitcoin Core 27.0 in 2024 (next year), not the soon upcoming 26.0 next month. This pull request includes three small cleanups to make use of C++20 features. If any issues are detected before or after merge, this should be easy to revert. If no issues arise, it should be fine to make use of more involved C++20 features later on. ACKs for top commit: fanquake: ACK fa6e50d Tree-SHA512: 244d79bfb0b750a4bdd713f40573b9ca33816fb84b6c84a58f027b9d7d4bb0cc4f18642959e4cf3d094808a69e5b8a327ca8521d7c0c08af27dacb5da3e78e71

…n to 10 fa5423b refactor: Remove unused gcc-9 workaround in txrequest (MarcoFalke) fa918d3 Always enable -Wsuggest-override (MarcoFalke) faea58e Bump g++ minimum supported version to 10 (MarcoFalke) Pull request description: All supported operating systems ship with g++ 10 (or later), so bumping the minimum should not cause any issues. The bump allows to drop some now-unused workarounds. For reference: * https://packages.debian.org/bullseye/g++ (`g++-10`) * https://packages.ubuntu.com/focal/g++-10 * FreeBSD 12/13 ships with g++ 12 * CentOS-like 9 ships with g++ 11 * OpenSuse Tumbleweed ships with g++ 13 https://software.opensuse.org/package/gcc13-c++ (No idea about OpenSuse Leap) This is for Bitcoin Core 27.0 in 2024 (next year), not the soon upcoming 26.0 next month. ACKs for top commit: fanquake: ACK fa5423b Tree-SHA512: 6f0697ae4c0f578873591b7872bf158aba3af17f171c3556b593a70ec379bf94c7a9dd7697e8e79173edd4ac3c81a376e0cbbc0cfabde1a1cfe5f9b5eaea6831

fa6e50d fuzz: Use C++20 starts_with in rpc.cpp (MarcoFalke) faa4838 Revert "tracepoints: Disables `-Wgnu-zero-variadic-macro-arguments` to compile without warnings" (MarcoFalke) fae3b77 refactor: Drop unused _Pragma to ignore -Wgnu-zero-variadic-macro-arguments (MarcoFalke) fa02fc0 refactor: modernize-use-default-member-init for bit-fields (C++20) (MarcoFalke) fa67f09 build: Require C++20 compiler (MarcoFalke) Pull request description: C++20 allows to write safer code, because it allows to enforce more stuff at compile time (`constinit`, `conteval`, `constexpr`, `std::span`, ...). Also, it allows to write less verbose and easier to understand code (C++ 20 Concepts). See bitcoin#23363 and https://en.cppreference.com/w/cpp/compiler_support#cpp20 With g++-10 (bitcoin#28348) and clang-13 (bitcoin#28210), there is broad support for almost all features of C++20. It should be fine to require a C++20 compiler for Bitcoin Core 27.0 in 2024 (next year), not the soon upcoming 26.0 next month. This pull request includes three small cleanups to make use of C++20 features. If any issues are detected before or after merge, this should be easy to revert. If no issues arise, it should be fine to make use of more involved C++20 features later on. ACKs for top commit: fanquake: ACK fa6e50d Tree-SHA512: 244d79bfb0b750a4bdd713f40573b9ca33816fb84b6c84a58f027b9d7d4bb0cc4f18642959e4cf3d094808a69e5b8a327ca8521d7c0c08af27dacb5da3e78e71

…n to 10 fa5423b refactor: Remove unused gcc-9 workaround in txrequest (MarcoFalke) fa918d3 Always enable -Wsuggest-override (MarcoFalke) faea58e Bump g++ minimum supported version to 10 (MarcoFalke) Pull request description: All supported operating systems ship with g++ 10 (or later), so bumping the minimum should not cause any issues. The bump allows to drop some now-unused workarounds. For reference: * https://packages.debian.org/bullseye/g++ (`g++-10`) * https://packages.ubuntu.com/focal/g++-10 * FreeBSD 12/13 ships with g++ 12 * CentOS-like 9 ships with g++ 11 * OpenSuse Tumbleweed ships with g++ 13 https://software.opensuse.org/package/gcc13-c++ (No idea about OpenSuse Leap) This is for Bitcoin Core 27.0 in 2024 (next year), not the soon upcoming 26.0 next month. ACKs for top commit: fanquake: ACK fa5423b Tree-SHA512: 6f0697ae4c0f578873591b7872bf158aba3af17f171c3556b593a70ec379bf94c7a9dd7697e8e79173edd4ac3c81a376e0cbbc0cfabde1a1cfe5f9b5eaea6831

fa6e50d fuzz: Use C++20 starts_with in rpc.cpp (MarcoFalke) faa4838 Revert "tracepoints: Disables `-Wgnu-zero-variadic-macro-arguments` to compile without warnings" (MarcoFalke) fae3b77 refactor: Drop unused _Pragma to ignore -Wgnu-zero-variadic-macro-arguments (MarcoFalke) fa02fc0 refactor: modernize-use-default-member-init for bit-fields (C++20) (MarcoFalke) fa67f09 build: Require C++20 compiler (MarcoFalke) Pull request description: C++20 allows to write safer code, because it allows to enforce more stuff at compile time (`constinit`, `conteval`, `constexpr`, `std::span`, ...). Also, it allows to write less verbose and easier to understand code (C++ 20 Concepts). See bitcoin#23363 and https://en.cppreference.com/w/cpp/compiler_support#cpp20 With g++-10 (bitcoin#28348) and clang-13 (bitcoin#28210), there is broad support for almost all features of C++20. It should be fine to require a C++20 compiler for Bitcoin Core 27.0 in 2024 (next year), not the soon upcoming 26.0 next month. This pull request includes three small cleanups to make use of C++20 features. If any issues are detected before or after merge, this should be easy to revert. If no issues arise, it should be fine to make use of more involved C++20 features later on. ACKs for top commit: fanquake: ACK fa6e50d Tree-SHA512: 244d79bfb0b750a4bdd713f40573b9ca33816fb84b6c84a58f027b9d7d4bb0cc4f18642959e4cf3d094808a69e5b8a327ca8521d7c0c08af27dacb5da3e78e71

…n to 10 fa5423b refactor: Remove unused gcc-9 workaround in txrequest (MarcoFalke) fa918d3 Always enable -Wsuggest-override (MarcoFalke) faea58e Bump g++ minimum supported version to 10 (MarcoFalke) Pull request description: All supported operating systems ship with g++ 10 (or later), so bumping the minimum should not cause any issues. The bump allows to drop some now-unused workarounds. For reference: * https://packages.debian.org/bullseye/g++ (`g++-10`) * https://packages.ubuntu.com/focal/g++-10 * FreeBSD 12/13 ships with g++ 12 * CentOS-like 9 ships with g++ 11 * OpenSuse Tumbleweed ships with g++ 13 https://software.opensuse.org/package/gcc13-c++ (No idea about OpenSuse Leap) This is for Bitcoin Core 27.0 in 2024 (next year), not the soon upcoming 26.0 next month. ACKs for top commit: fanquake: ACK fa5423b Tree-SHA512: 6f0697ae4c0f578873591b7872bf158aba3af17f171c3556b593a70ec379bf94c7a9dd7697e8e79173edd4ac3c81a376e0cbbc0cfabde1a1cfe5f9b5eaea6831

fa6e50d fuzz: Use C++20 starts_with in rpc.cpp (MarcoFalke) faa4838 Revert "tracepoints: Disables `-Wgnu-zero-variadic-macro-arguments` to compile without warnings" (MarcoFalke) fae3b77 refactor: Drop unused _Pragma to ignore -Wgnu-zero-variadic-macro-arguments (MarcoFalke) fa02fc0 refactor: modernize-use-default-member-init for bit-fields (C++20) (MarcoFalke) fa67f09 build: Require C++20 compiler (MarcoFalke) Pull request description: C++20 allows to write safer code, because it allows to enforce more stuff at compile time (`constinit`, `conteval`, `constexpr`, `std::span`, ...). Also, it allows to write less verbose and easier to understand code (C++ 20 Concepts). See bitcoin#23363 and https://en.cppreference.com/w/cpp/compiler_support#cpp20 With g++-10 (bitcoin#28348) and clang-13 (bitcoin#28210), there is broad support for almost all features of C++20. It should be fine to require a C++20 compiler for Bitcoin Core 27.0 in 2024 (next year), not the soon upcoming 26.0 next month. This pull request includes three small cleanups to make use of C++20 features. If any issues are detected before or after merge, this should be easy to revert. If no issues arise, it should be fine to make use of more involved C++20 features later on. ACKs for top commit: fanquake: ACK fa6e50d Tree-SHA512: 244d79bfb0b750a4bdd713f40573b9ca33816fb84b6c84a58f027b9d7d4bb0cc4f18642959e4cf3d094808a69e5b8a327ca8521d7c0c08af27dacb5da3e78e71

85e480a doc: Update NetBSD Build Guide (Hennadii Stepanov) Pull request description: This PR updates the NetBSD Build Guide to reflect: - the recent NetBSD Release - GCC minimum supported version update (#28348 and #29091) - Python minimum supported version update (#28211) Also a smaller package set has been suggested: - `boost-headers` instead of the full `boost` - `qt5-qtbase qt5-qttools` instead of the full `qt5` (similar to #29932 and #29947). ACKs for top commit: maflcko: utACK 85e480a Tree-SHA512: 0848b6f169a00f2da78eea452fd116193aece853680f4e615ba1df654246ec2a9d1600a4cfb238eb9305b72bbe4b2873519bf1e2987eaaf48aba900c64e85a48

maflcko changed the title ~~Bump g++ minimum supported version to 10~~ build: Bump g++ minimum supported version to 10 Aug 27, 2023

DrahtBot added the Build system label Aug 27, 2023

maflcko added this to the 27.0 milestone Aug 27, 2023

maflcko mentioned this pull request Aug 27, 2023

build: Require C++20 compiler #28349

Merged

maflcko added the Needs rebase label Aug 27, 2023

This was referenced Aug 27, 2023

Bump python minimum supported version to 3.9 #28211

Merged

build: Bump clang minimum supported version to 13 #28210

Merged

DrahtBot removed the Needs rebase label Aug 27, 2023

DrahtBot mentioned this pull request Aug 27, 2023

build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is set #25972

Merged

DrahtBot added CI failed and removed CI failed labels Sep 3, 2023

maflcko force-pushed the 2308-g++-10- branch from b569c3f to fad0ba1 Compare October 24, 2023 16:58

maflcko marked this pull request as ready for review October 24, 2023 16:59

maflcko added the DrahtBot Guix build requested label Oct 24, 2023

DrahtBot added Needs rebase CI failed labels Oct 24, 2023

DrahtBot removed the DrahtBot Guix build requested label Oct 24, 2023

maflcko force-pushed the 2308-g++-10- branch from fad0ba1 to fa91945 Compare October 25, 2023 05:53

DrahtBot removed Needs rebase CI failed labels Oct 25, 2023

fanquake reviewed Oct 30, 2023

View reviewed changes

configure.ac Outdated Show resolved Hide resolved

Bump g++ minimum supported version to 10

faea58e

Also, enable -Werror=maybe-uninitialized in ci/test/00_setup_env_native_qt5.sh

maflcko force-pushed the 2308-g++-10- branch from fa91945 to eeee164 Compare October 30, 2023 14:14

MarcoFalke added 2 commits October 30, 2023 15:18

Always enable -Wsuggest-override

fa918d3

refactor: Remove unused gcc-9 workaround in txrequest

fa5423b

maflcko force-pushed the 2308-g++-10- branch from eeee164 to fa5423b Compare October 30, 2023 14:19

fanquake approved these changes Oct 30, 2023

View reviewed changes

fanquake merged commit 7d6c646 into bitcoin:master Oct 30, 2023

maflcko deleted the 2308-g++-10- branch October 30, 2023 14:59

hebasto mentioned this pull request May 20, 2024

doc: Update NetBSD Build Guide #30143

Merged

bitcoin locked and limited conversation to collaborators Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: Bump g++ minimum supported version to 10#28348

build: Bump g++ minimum supported version to 10#28348
fanquake merged 3 commits intobitcoin:masterfrom
maflcko:2308-g++-10-

maflcko commented Aug 27, 2023 •

edited

Loading

Uh oh!

DrahtBot commented Aug 27, 2023 •

edited

Loading

Uh oh!

fanquake commented Sep 12, 2023

Uh oh!

DrahtBot commented Oct 24, 2023

Uh oh!

Uh oh!

fanquake left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

maflcko commented Aug 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Aug 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage

Reviews

Conflicts

Uh oh!

fanquake commented Sep 12, 2023

Uh oh!

DrahtBot commented Oct 24, 2023

Guix builds (on x86_64)

Uh oh!

Uh oh!

fanquake left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

maflcko commented Aug 27, 2023 •

edited

Loading

DrahtBot commented Aug 27, 2023 •

edited

Loading