ci, windows: Do not run extended functional tests for pull requests#28360
ci, windows: Do not run extended functional tests for pull requests#28360fanquake merged 1 commit intobitcoin:masterfrom
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
hebasto
force-pushed
the
230828-gha-win
branch
from
b635549 to
0cf1c9e
Compare
hebasto
force-pushed
the
230828-gha-win
branch
from
0cf1c9e to
f8ccdb3
Compare
|
cc @MarcoFalke |
.github/workflows/ci.yml
Outdated
|
|
||
| - name: Run functional tests | ||
| env: | ||
| TEST_RUNNER_EXTRA: ${{ github.event_name != 'pull_request' && '--extended --exclude feature_dbcrash' || '' }} |
There was a problem hiding this comment.
| TEST_RUNNER_EXTRA: ${{ github.event_name != 'pull_request' && '--extended --exclude feature_dbcrash' || '' }} | |
| TEST_RUNNER_EXTRA: ${{ github.event_name != 'pull_request' && '--extended' || '' }} |
If there is a reason to exclude this, it should be mentioned
There was a problem hiding this comment.
feature_dbcrash.py | ✓ Passed | 7086 s
There was a problem hiding this comment.
If there are any downsides, you can skip the functional tests on the master branch completely on job_id % n == 0, where n is the down-scaling factor, but then run them completely otherwise?
There was a problem hiding this comment.
It takes one runner busy approximately twice longer than other runners. Of course, not a big deal, considering we are provided with 20 runners.
There was a problem hiding this comment.
If there are any downsides, you can skip the functional tests on the master branch completely on
job_id % n == 0, wherenis the down-scaling factor, but then run them completely otherwise?
Let's left it as is and see how it will go.
This change is intended to speed up the CI feedback for pull requests.
hebasto
force-pushed
the
230828-gha-win
branch
from
f8ccdb3 to
62ab3e9
Compare
|
lgtm ACK 62ab3e9 if https://github.com/hebasto/bitcoin/actions/runs/6023862001/job/16341417883 is green |
|
It is green |
|
cc @fanquake |
…s for pull requests 62ab3e9 ci, windows: Do not run extended functional tests for pull requests (Hennadii Stepanov) Pull request description: This PR is intended to speed up the CI feedback for pull requests: - a [PR](https://github.com/bitcoin/bitcoin/actions/runs/6019964104?pr=28196) opened against the current master branch:  - this PR:  Suggested in bitcoin#28173 (comment): > An alternative would be to run them on non-pr pushes only. Failures should be rare enough to deal with them post-merge. ACKs for top commit: MarcoFalke: lgtm ACK 62ab3e9 if https://github.com/hebasto/bitcoin/actions/runs/6023862001/job/16341417883 is green Tree-SHA512: e937efc5c03290f5d246ce1b0638dc72f39ef1d509ba5d2063f92bfe9157c602e6a952a9558dfc6413bbc5209fe55280b3278a0e4079773b8cc9ff236c8f9246
4 participants
This PR is intended to speed up the CI feedback for pull requests:
a PR opened against the current master branch:
this PR:
Suggested in #28173 (comment):