ci: Use nproc over MAKEJOBS in 01_base_install#28504
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
maflcko
force-pushed
the
2309-ci-nproc-
branch
from
fa3adca to
7e242a1
Compare
maflcko
force-pushed
the
2309-ci-nproc-
branch
from
7e242a1 to
fa6f6f7
Compare
maflcko
force-pushed
the
2309-ci-nproc-
branch
from
fa6f6f7 to
fa3b5e5
Compare
|
Concept ACK |
|
I assume I'm missing some context here, but ninja is parallel using cpu count by default. Do we really need to specify here |
|
Yeah, I kept it to be consistent with |
4 participants
Currently
$MAKEJOBSis the default value in01_base_install.shwhen building the container image.This problem can't be fixed (see below), so just use
nprocfor now.Other solutions would be bad:
MAKEJOBSas a dockerfile env would create a new image if the number of tasks are changed, seems verbose and confusing.masteras-is would leave CPUs unused if there are more than4.