contrib/bash-completions: use package naming conventions#28507
contrib/bash-completions: use package naming conventions#28507fanquake merged 1 commit intobitcoin:masterfrom
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
This naming scheme supports auto-detection and on-demand loading of completions. See https://github.com/scop/bash-completion/blob/ba109693ee2284f6a82f8f0e1563baf071252df9/README.md#faq, section "Where should I put it to be sure that interactive bash shells will find it and source it". Previously, distro package maintainers had to rename these files manually.
erikarvstedt
force-pushed
the
rename-bash-completions
branch
from
537d439 to
360b917
Compare
|
cc @prusnak |
|
Seems ok, and lines up with the other .fish completions. I see the discussion in fort-nix/nix-bitcoin#647. I guess downstreams like https://github.com/gentoo/gentoo/blob/af3998740256e5f8f8618ae248edd512fff5f0eb/net-p2p/bitcoin-cli/bitcoin-cli-0.21.0.ebuild#L101C2-L101C2, or https://github.com/archlinuxarm/PKGBUILDs/blob/d645584b373f39c5aa750bd4729ee812ad8fc5c4/extra/bitcoin/PKGBUILD#L96 can be pinged to update their integrations. cc @willcl-ark |
|
ACK 360b917 Agree that this matches the spec and best practice, and also tested that simply copying completions to /usr/share/bash-completion/completions had them work automatically as expected. I suppose with cmake incoming there's no point in adding a configure flag to install completions with |
|
Added a label so we don't forget to mention this in the 26.x release notes. |
|
Release note to be added in #29023. |
5 participants
Copy of commit msg
This naming scheme supports auto-detection and on-demand loading of completions.
See
https://github.com/scop/bash-completion/blob/ba109693ee2284f6a82f8f0e1563baf071252df9/README.md#faq,
section "Where should I put it to be sure that interactive bash shells will find it and source it", keyword
foo.bash.Previously, distro package maintainers had to rename these files manually.