Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
added 2 commits
September 26, 2023 16:24
Github-Pull: bitcoin#27777 Rebased-From: fa9c65a
Github-Pull: bitcoin#27777 Rebased-From: fa12307
fanquake
force-pushed
the
further_24_x_backports
branch
from
f009d26 to
f882b40
Compare
This should avoid a race where the kill is not done when spinning up the new container. podman stop waits 10 seconds by default. Github-Pull: bitcoin#27844 Rebased-From: faaa627
Github-Pull: bitcoin#28452 Rebased-From: 3fcd7fc
This reduces chances of having old estimates in fee_estimates.dat. Github-Pull: bitcoin#27622 Rebased-From: 5b886f2
Old fee estimates could cause transactions to become stuck in the mempool. This commit prevents the node from using stale estimates from an old file. Github-Pull: bitcoin#27622 Rebased-From: 3eb241a
If -acceptstalefeeestimates option is passed stale fee estimates can now be read when operating in regtest environments. Additionally, this commit updates all declarations of the CBlockPolicyEstimator class to include a the second constructor variable. Github-Pull: bitcoin#27622 Rebased-From: cf219f2
This commit adds tests to ensure that old fee_estimates.dat files are not read and that fee_estimates are periodically flushed to the fee_estimates.dat file. Additionaly it tests the -regtestonly option -acceptstalefeeestimates. Github-Pull: bitcoin#27622 Rebased-From: d2b39e0
fanquake
force-pushed
the
further_24_x_backports
branch
from
f882b40 to
cb5512d
Compare
Member
Author
|
Pushed some more commits to improve the CI. |
This was referenced Sep 26, 2023
Github-Pull: bitcoin#27834 Rebased-From: fa22538
Tee `arm_container` does not support 32-bit mode anymore. See: bitcoin#27879 Github-Pull: bitcoin#27886 Rebased-From: 016fe6d
Github-Pull: bitcoin#28543 Rebased-From: 79ef528
See https://codereview.qt-project.org/c/qt/qtbase/+/482392. Github-Pull: bitcoin#28571 Rebased-From: 848eec0
Member
Author
|
I think this is currently all we are going to backport to 24.x, so this is ready for review. |
stickies-v
approved these changes
Oct 5, 2023
Contributor
stickies-v
left a comment
stickies-v
left a comment
There was a problem hiding this comment.
ACK 9077f21
A couple diffs from the original commits, but all changes look good to me:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports to the 24.x branch. Currently:
amd64container in "ARM" task #27886qtpackage build with new Xcode 15 linker #28543