bench: remove NO_THREAD_SAFETY_ANALYSIS usage#28557
Merged
glozow merged 1 commit intobitcoin:masterfrom Oct 2, 2023
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
fanquake
force-pushed
the
bench_drop_thread_safety
branch
from
0d81d2b to
a3a90b3
Compare
fanquake
force-pushed
the
bench_drop_thread_safety
branch
from
a3a90b3 to
d67aa25
Compare
Member
|
lgtm ACK d67aa25 |
glozow
reviewed
Oct 2, 2023
Frank-GER
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 5, 2023
d67aa25 bench: drop NO_THREAD_SAFETY_ANALYSIS from disconnected_txs (fanquake) Pull request description: Followup to bitcoin#28385 (comment). ACKs for top commit: MarcoFalke: lgtm ACK d67aa25 hebasto: ACK d67aa25, tested on Ubuntu 22.04 with clang 18.0. glozow: utACK d67aa25 Tree-SHA512: a9a9a8cc70a50d4fbd51779a3203bbc2a29d354b557e8a99cfd649d5998b71ff1087f5bae7170471bed9a917a93c8f3351ae90c9a6e87d88928c35912d007b64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #28385 (comment).