Bugfix: configure: Correct check for fuzz binary needing a main function#28564
Bugfix: configure: Correct check for fuzz binary needing a main function#28564luke-jr wants to merge 1 commit intobitcoin:masterfrom
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Can you add steps to reproduce the bug? In any case, no objection, but I wonder if this is worth it, given that the cmake transition should be happening soon(TM) after the branch-off. So it may be better to spend effort on checking that cmake does the right thing. |
Run |
hebasto
left a comment
hebasto
left a comment
There was a problem hiding this comment.
ACK 8f6ca58.
The ./configure script logs are as follow:
- in the master branch:
checking whether main function is needed for fuzz binary... checking whether the linker accepts ... no
yes
or
checking whether main function is needed for fuzz binary... checking whether the linker accepts ... yes
no
- in this PR branch:
checking whether main function is needed for fuzz binary... yes
or
checking whether main function is needed for fuzz binary... no
I'm using the same approach in the new CMake-based build system (see hebasto#43).
|
So this is only to fix a test-only debug-only output? Not sure. I guess it can be merged, if cmake does not make it into 27.x. Otherwise it seems odd to change this, when the code will be removed either way before any user will even run or see it. |
|
🐙 This pull request conflicts with the target branch and needs rebase. |
5 participants
Fixes #28563