doc: assumeutxo prune and index notes#28618
Merged
ryanofsky merged 1 commit intobitcoin:masterfrom Oct 23, 2023
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Merged
Sjors
force-pushed
the
2023/10/assume-prune-index
branch
from
33f34c0 to
89db87e
Compare
flack
reviewed
Oct 9, 2023
flack
reviewed
Oct 9, 2023
jamesob
reviewed
Oct 10, 2023
Contributor
jamesob
left a comment
jamesob
left a comment
There was a problem hiding this comment.
ACK modulo outstanding comments
Member
Author
|
Addressed the above comments. |
Sjors
force-pushed
the
2023/10/assume-prune-index
branch
from
89db87e to
03f8208
Compare
vostrnad
reviewed
Oct 14, 2023
| indexes will continue to build all the way to the tip. | ||
|
|
||
| For indexes that support pruning, note that no pruning will take place between | ||
| the snapshot and the tip, until the background sync has completed - after which |
There was a problem hiding this comment.
Suggested change
| the snapshot and the tip, until the background sync has completed - after which | |
| the snapshot and the tip until the background sync has completed, after which |
Frank-GER
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 28, 2023
03f8208 doc: assumeutxo prune and index notes (Sjors Provoost) Pull request description: Based on recent comments on bitcoin#27596. ACKs for top commit: pablomartin4btc: re ACK 03f8208 ryanofsky: ACK 03f8208. Nice changes, these seem like very helpful notes Tree-SHA512: fe651b49f4d667400a3655899f27a96dd1eaf67cf9215fb35db5f44fb8c0313e7d541518be6791fec93392df24b909793f3886adb808e53228ed2a291165639d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on recent comments on #27596.