Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Member
|
Concept ACK. |
Contributor
fanquake
force-pushed
the
zeromq_4_3_5
branch
from
800e8c1 to
986d7fe
Compare
Member
|
My Guix builds: |
Contributor
|
Guix builds: |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 27, 2024
986d7fe depends: zeromq 4.3.5 (fanquake) Pull request description: First new point release of zeromq in two and a half years. Mostly bug fixes; the project also completed a relicense to the "Mozilla Public License". See https://github.com/zeromq/libzmq/releases/tag/v4.3.5. ACKs for top commit: hebasto: ACK 986d7fe, I have reviewed the code and it looks OK. TheCharlatan: ACK 986d7fe Tree-SHA512: cdd6abfbbe10873c1ca267fed648c2e6ff17a4aff50c414924006e63fa39d501e803f8893a5cd966a2078b5c077f2578e482483e6723ea6f5760f16211d40998
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Sep 27, 2024
801c4fc build: followup to 29488 applied to gmp (pasta) 4b704a6 Merge bitcoin#28627: depends: zeromq 4.3.5 (fanquake) 0e6cb98 Merge bitcoin#26421: build: copy config.{guess,sub} post autogen in zmq package (fanquake) cd33b69 Merge bitcoin#29488: depends: always configure with `--with-pic` (fanquake) 1b88674 Merge bitcoin#29287: depends: Do not override `CFLAGS` when building SQLite with `DEBUG=1` (fanquake) f50fb6e Merge bitcoin#26998: depends: ensure we are appending to sqlite cflags (Andrew Chow) 25a594f Merge bitcoin#25987: build: compile depends sqlite with more recommended options (Andrew Chow) d725c58 Merge bitcoin#27312: depends: qrencode 4.1.1 (fanquake) 482e5bb Merge bitcoin#27462: depends: fix compiling bdb with clang-16 on aarch64 (fanquake) f0a53c9 Merge bitcoin#26994: depends: define `__BSD_VISIBLE` for FreeBSD bdb build (merge-script) b1ac992 Merge bitcoin#26073: build: fix depends bdb compilation for BSDs (fanquake) 45e0f6e Merge bitcoin#25763: bdb: disable Werror for format-security (fanquake) Pull request description: ## Issue being fixed or feature implemented First batch of PRs which lead towards cmake, focusing on having nothing or very little done out of order / with significant conflicts ## What was done? batch of 11 backports which lead towards cmake ## How Has This Been Tested? Built locally, seems to work, let's see CI ## Breaking Changes ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK 801c4fc knst: utACK 801c4fc Tree-SHA512: b8b5299da9d82ab485ba5141ea12ba5c606f1a783b34c957d61e0a68d45865754fbc8bcbb0c5eabe3d410ff6262ce26789cf4a3af696905f7b7908e523c97816
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First new point release of zeromq in two and a half years. Mostly bug fixes; the project also completed a relicense to the "Mozilla Public License".
See https://github.com/zeromq/libzmq/releases/tag/v4.3.5.