test: assumeutxo file with unknown block hash#28666
Merged
ryanofsky merged 1 commit intobitcoin:masterfrom Oct 18, 2023
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
maflcko
reviewed
Oct 17, 2023
Member
maflcko
left a comment
maflcko
left a comment
There was a problem hiding this comment.
lgtm ACK 5958f7b86fb9e11406552cdf7b55055cf65d202b
fjahr
force-pushed
the
2023-10-au-tests-2
branch
from
5958f7b to
621db2f
Compare
Member
|
lgtm ACK 621db2f |
| error_details = f"assumeutxo block hash in snapshot metadata not recognized ({bad_snapshot_block_hash})" | ||
| assert_raises_rpc_error(-32603, f"Unable to load UTXO snapshot, {error_details}", self.nodes[1].loadtxoutset, bad_snapshot_path) | ||
| prev_block_hash = self.nodes[0].getblockhash(SNAPSHOT_BASE_HEIGHT - 1) | ||
| bogus_block_hash = "0" * 64 # Represents any unknown block hash |
Member
There was a problem hiding this comment.
This is good.
nit:
Suggested change
| bogus_block_hash = "0" * 64 # Represents any unknown block hash | |
| bogus_block_hash = "0" * 64 # Represents any invalid/ not recognized block hash |
theStack
approved these changes
Oct 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes care of one of the open Todos in the assumeutxo functional test. Since an unknown block could be any hash, I simply chose one placeholder, it could also be a random string though.