test: check assumeutxo file for changed outpoint index + de-duplications#28669
Merged
achow101 merged 2 commits intobitcoin:masterfrom Oct 20, 2023
Merged
test: check assumeutxo file for changed outpoint index + de-duplications#28669achow101 merged 2 commits intobitcoin:masterfrom
achow101 merged 2 commits intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Oct 18, 2023
Member
|
nit: duplicate is written with |
fanquake
changed the title
maflcko
reviewed
Oct 19, 2023
fjahr
force-pushed
the
2023-10-au-tests
branch
from
b08b72e to
1983f2c
Compare
fjahr
force-pushed
the
2023-10-au-tests
branch
from
1983f2c to
d322368
Compare
Contributor
Author
|
Addressed @maflcko 's feedback and rebased. |
Member
|
lgtm ACK d322368 |
Member
|
fuzz timeout can be ignored for now |
Member
|
ACK d322368 |
Frank-GER
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 21, 2023
… index + de-duplications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also doing some de-duplications. I kept the second commit separate for now as I am not 100% if this is overdoing it and makes it harder to reason about. But it also makes it easier to add more cases where we change more data.