fuzz: Delete i2p fuzz test#28692
Merged
fanquake merged 1 commit intobitcoin:masterfrom Oct 20, 2023
Hidden character warning
The head ref may contain hidden characters: "2023-10-fuzz-\ud83d\uddd1\ufe0f"
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Member
Author
|
The lacking coverage was discussed before: #21387 (comment) |
Member
|
lgtm ACK dd4dcbd Thanks for reminding me that I brought up the issue a long time ago already. Given that no one stepped up in the meantime to maintain it, it should be fine to remove for now. Once and if there is someone to maintain it, it is trivial to add it back in by reverting this commit, or otherwise. |
Frank-GER
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 21, 2023
dd4dcbd [fuzz] Delete i2p target (dergoegge) Pull request description: closes bitcoin#28665 The target is buggy and doesn't reach basic coverage. ACKs for top commit: maflcko: lgtm ACK dd4dcbd glozow: ACK dd4dcbd, agree it's better to delete this test until somebody wants to write a better one Tree-SHA512: b6ca6cad1773b1ceb6e5ac0fd501ea615f66507ef811745799deaaa4460f1700d96ae03cf55b740a96ed8cd2283b3d6738cd580ba97f2af619197d6c4414ca21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #28665
The target is buggy and doesn't reach basic coverage.