build: Include config/bitcoin-config.h explicitly in util/trace.h#28693
Merged
fanquake merged 1 commit intobitcoin:masterfrom Oct 23, 2023
Merged
build: Include config/bitcoin-config.h explicitly in util/trace.h#28693fanquake merged 1 commit intobitcoin:masterfrom
config/bitcoin-config.h explicitly in util/trace.h#28693fanquake merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Member
|
Missing |
The `ENABLE_TRACING` macro is expected to be defined in the `config/bitcoin-config.h` header. Therefore, the current code is error-prone as it depends on whether the `config/bitcoin-config.h` header was included before or not.
hebasto
changed the title
config/bitcoin-config.h explicitly in util/trace.hconfig/bitcoin-config.h explicitly in util/trace.h
Member
Author
Thanks! Added. |
fanquake
approved these changes
Oct 23, 2023
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Oct 28, 2023
The `ENABLE_TRACING` macro is expected to be defined in the `config/bitcoin-config.h` header. Therefore, the current code is error-prone as it depends on whether the `config/bitcoin-config.h` header was included before or not. Github-Pull: bitcoin#28693 Rebased-From: 6bdff42
Frank-GER
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 28, 2023
…tly in `util/trace.h` 6bdff42 build: Include `config/bitcoin-config.h` explicitly in `util/trace.h` (Hennadii Stepanov) Pull request description: The `ENABLE_TRACING` macro is expected to be defined in the `config/bitcoin-config.h` header. Therefore, the current code is error-prone as it depends on whether the `config/bitcoin-config.h` header was included before or not. This bug was noticed while working on CMake [stuff](hebasto#37). ACKs for top commit: fanquake: ACK 6bdff42 Tree-SHA512: 22c4fdeb51628814050eb99a83db4268a4f3106207eeef918a07214bbc52f2b22490f6b05fcb96216f147afa4197c51102503738131e2583e750b6d195747a49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ENABLE_TRACINGmacro is expected to be defined in theconfig/bitcoin-config.hheader.Therefore, the current code is error-prone as it depends on whether the
config/bitcoin-config.hheader was included before or not.This bug was noticed while working on CMake stuff.