Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Member
This was referenced Oct 30, 2023
This should fix the bug reported in bitcoin#28246 (comment), which caused the GUI to not detect the destination type of recipients, thus picking the wrong change destination type. Also, add missing lifetimebound attribute to a getter method. GitHub-Pull: bitcoin#28728 Rebased-From: 1111475
Co-authored-by: Vasil Dimov <[email protected]> GitHub-Pull: bitcoin#28695 Rebased-From: cf70a8d
Github-Pull: bitcoin#28695 Rebased-From: 5cf4d26
Github-Pull: bitcoin#28698 Rebased-from: 4a5be10
…rameters Co-authored-by: Russell Yanofsky <[email protected]> Co-authored-by: Sebastian Falbesoner <[email protected]> Github-Pull: bitcoin#28698 Reabsed-From: 811067c
The zip for codesigned MacOS distribution needs to have all files have the same timestamp. These files also need to be included in the zip as zip is not automatically recursive. We use the same pattern for zip as is done for the other zip files produced by guix. Github-Pull: bitcoin#28757 Rebased-From: f6f18ee
Fixes bitcoin#28449 Github-Pull: bitcoin#28759 Rebased-From: 79539fb
fanquake
force-pushed
the
backports_26_0_rc2
branch
from
b60a59b to
9c29048
Compare
Member
Author
|
Added final backports, and bumped version + manpages. We also just merged a translation update, which I rebased this branch on top of. |
hebasto
approved these changes
Oct 31, 2023
sedited
approved these changes
Oct 31, 2023
Contributor
sedited
left a comment
sedited
left a comment
There was a problem hiding this comment.
lgtm ACK 9c29048dac5dfa5a06323b350156b1212b87d56d
This commits fixes a crash bug that can be caused with the following steps: - change to the "Transactions" view - right-click on an arbitrary transaction -> "Show transaction details" - close the transaction detail window again - select "Settings" -> "Mask values" The problem is that the list of opened dialogs, tracked in the member variable `m_opened_dialogs`, is only ever appended with newly opened transaction detail dialog pointers, but never removed. This leads to dangling pointers in the list, and if the "Mask values" menu item is selected, a crash is caused in the course of trying to close the opened transaction detail dialogs (see `closeOpenedDialogs()` method). Fix this by removing the pointer from the list if the corresponding widget is destroyed. Github-Pull: bitcoin-core/gui#774 Rebased-From: e26e665
fanquake
force-pushed
the
backports_26_0_rc2
branch
from
9c29048 to
e4e8479
Compare
hebasto
approved these changes
Nov 1, 2023
Member
There was a problem hiding this comment.
re-ACK e4e8479, only a backport of bitcoin-core/gui#774 added since my recent review.
sedited
approved these changes
Nov 1, 2023
Member
|
ACK e4e8479 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports for v26.0rc2: