Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
fanquake
force-pushed
the
backports_25_2
branch
from
84d9504 to
05cb867
Compare
fanquake
force-pushed
the
backports_25_2
branch
from
b2a78a0 to
560eb22
Compare
This commits fixes a crash bug that can be caused with the following steps: - change to the "Transactions" view - right-click on an arbitrary transaction -> "Show transaction details" - close the transaction detail window again - select "Settings" -> "Mask values" The problem is that the list of opened dialogs, tracked in the member variable `m_opened_dialogs`, is only ever appended with newly opened transaction detail dialog pointers, but never removed. This leads to dangling pointers in the list, and if the "Mask values" menu item is selected, a crash is caused in the course of trying to close the opened transaction detail dialogs (see `closeOpenedDialogs()` method). Fix this by removing the pointer from the list if the corresponding widget is destroyed. Github-Pull: bitcoin-core/gui#774 Rebased-From: e26e665
fanquake
force-pushed
the
backports_25_2
branch
from
560eb22 to
c58de5a
Compare
The crash would happen when querying a mempool transaction with verbosity=2, while pruning. Github-Pull: bitcoin#29003 Rebased-From: 494a926
This fails on master without the previous commit. Github-Pull: bitcoin#29003 Rebased-From: 9075a44
fanquake
force-pushed
the
backports_25_2
branch
from
c58de5a to
115e31b
Compare
stickies-v
reviewed
Jan 15, 2024
Contributor
stickies-v
left a comment
stickies-v
left a comment
There was a problem hiding this comment.
LGTM 115e31b8e902c02ad4b342843c4811b5e74415d0 modulo small release notes issue. Also, PR description needs to be updated to remove the reference to #28919.
Member
|
#29200 would be relevant. |
fanquake
force-pushed
the
backports_25_2
branch
from
115e31b to
53bbda5
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collecting backports for the 25.x branch. Currently: