refactor: VectorWriter and SpanReader without nVersion#28912
refactor: VectorWriter and SpanReader without nVersion#28912fanquake merged 2 commits intobitcoin:masterfrom
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
DrahtBot
changed the title
|
Shares its first commit with #28892 |
maflcko
force-pushed
the
2311-less-version-
branch
from
fabac1f to
86aea1c
Compare
maflcko
force-pushed
the
2311-less-version-
branch
from
86aea1c to
7f1b4b6
Compare
The field is unused, so remove it. This is also required for future commits.
The remaining places are handled easier outside a scripted-diff.
-BEGIN VERIFY SCRIPT-
sed --regexp-extended -i 's/CDataStream ([0-9a-zA-Z_]+)\(SER_[A-Z]+, [A-Z_]+_VERSION\);/DataStream \1{};/g' $( git grep -l CDataStream)
sed -i 's/, CDataStream/, DataStream/g' src/wallet/walletdb.cpp
-END VERIFY SCRIPT-
maflcko
force-pushed
the
2311-less-version-
branch
from
7f1b4b6 to
fae76a1
Compare
|
What are the places where CDataStream is still needed after this and what will happen to these? |
|
Should end up removed completely in #28451. |
|
ACK fae76a1 |
5 participants
The serialize version is unused, so remove it. This also allows to remove
GCS_SER_VERSIONand allows a scripted-diff to remove most ofCDataStream.