Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
This was referenced Dec 6, 2023
Github-Pull: bitcoin#29023 Rebased-From: 7d4e47d
Github-Pull: bitcoin#29023 Rebased-From: ca59375
fanquake
force-pushed
the
26_1_backports
branch
from
a17e975 to
188e023
Compare
Member
|
ACK 188e023d2fdab30b4a779a862b2c8b567bb15803 Checked diffs between Rebased-from commit hash and these commits themselves. |
fanquake
force-pushed
the
26_1_backports
branch
from
188e023 to
de8f082
Compare
Member
Author
|
Note that any tidy job failure here is currently related to #28992 (comment) (and should be fixed in future). |
fanquake
force-pushed
the
26_1_backports
branch
from
de8f082 to
2cf9b1b
Compare
fanquake
force-pushed
the
26_1_backports
branch
2 times, most recently
from
987d3d6 to
aae721f
Compare
Member
|
7e90b5938f4dbdba58355f55f785c9054055a912 has a typo in the commit message |
fanquake
force-pushed
the
26_1_backports
branch
from
aae721f to
cace1c6
Compare
fanquake
force-pushed
the
26_1_backports
branch
from
cace1c6 to
48772b0
Compare
Github-Pull: bitcoin#28992 Rebased-From: fa83b65
Github-Pull: bitcoin#28992 Rebased-From: fad2392
The crash would happen when querying a mempool transaction with verbosity=2, while pruning. Github-Pull: bitcoin#29003 Rebased-From: 494a926
This fails on master without the previous commit. Github-Pull: bitcoin#29003 Rebased-From: 9075a44
Co-authored-by: furszy <[email protected]> Github-Pull: bitcoin#28994 Rebased-From: 5cea25b
Useful for understanding what is going on internally when the software is running. Debug issues, and provide more accurate feedback to users. Github-Pull: bitcoin#28994 Rebased-From: 0c57557
Verify the transaction creation process does not produce a BnB solution when SFFO is enabled. This is currently problematic because it could require a change output. And BnB is specialized on changeless solutions. Co-authored-by: Andrew Chow <[email protected]> Co-authored-by: Murch <[email protected]> Github-Pull: bitcoin#28994 Rebased-From: 05e5ff1
Github-Pull: bitcoin#28994 Rebased-From: 576bee8
In the following-up commit, the wallet birth time will also be modified by the transactions scanning process. When a tx older than all descriptor's timestamp is detected. Github-Pull: bitcoin#28920 Rebased-From: b4306e3
As the user could have imported a descriptor with a newer timestamp (by blindly setting 'timestamp=now'), the wallet needs to update the birth time when it detects a transaction older than the oldest descriptor timestamp. Github-Pull: bitcoin#28920 Rebased-From: 75fbf44
To avoid scanning blocks, as assumed by a wallet with no generated keys or imported scripts, the default value for the birth time needs to be set to the maximum int64_t value. Once the first key is generated or the first script is imported, the legacy SPKM will update the birth time automatically. Github-Pull: bitcoin#28920 Rebased-From: 6f49737
Verifying the wallet updates the birth time accordingly when it detects a transaction with a time older than the oldest descriptor timestamp. This could happen when the user blindly imports a descriptor with 'timestamp=now'. Github-Pull: bitcoin#28920 Rebased-From: 83c6644
And add coverage for it Github-Pull: bitcoin#28920 Rebased-From: 1ce45ba
Homebrew attempts to check for outdated dependents or those with broken linkage. Such behavior might lead to failures when Homebrew updates them on old macOS images. This change prevents such behavior. Github-Pull: bitcoin#29080 Rebased-From: 43c3246
Github-Pull: bitcoin#29176 Rebased-From: faebf1d
fanquake
force-pushed
the
26_1_backports
branch
from
48772b0 to
7b79e54
Compare
sedited
approved these changes
Jan 4, 2024
glozow
reviewed
Jan 9, 2024
Member
Member
|
I'm planning to merge this now and open another batch of backports |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports for
26.x. Currently:HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECKto avoid unrelated failures #29080