refactor: Use std::span over Span#29119
Closed
maflcko wants to merge 2 commits intobitcoin:masterfrom
Closed
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/29119. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsNo conflicts as of last run. |
This was referenced Dec 20, 2023
Merged
obrusvit
reviewed
Dec 20, 2023
src/span.h
Outdated
maflcko
force-pushed
the
2312-std-span-
branch
from
1745cf8 to
99364d7
Compare
maflcko
force-pushed
the
2312-std-span-
branch
from
99364d7 to
0bb7722
Compare
This was referenced Jan 3, 2024
maflcko
force-pushed
the
2312-std-span-
branch
2 times, most recently
from
2936a4a to
d62c3a4
Compare
maflcko
force-pushed
the
2312-std-span-
branch
2 times, most recently
from
449a307 to
b7d9f25
Compare
maflcko
force-pushed
the
2312-std-span-
branch
from
b7d9f25 to
b80b8ec
Compare
This was referenced Jun 6, 2024
Member
|
Concept ACK, provided we're migrating to |
maflcko
force-pushed
the
2312-std-span-
branch
from
9bd1162 to
9b56f63
Compare
Member
Author
|
Next step would be bitcoin-core/leveldb-subtree#45 |
maflcko
force-pushed
the
2312-std-span-
branch
from
9b56f63 to
6067754
Compare
maflcko
force-pushed
the
2312-std-span-
branch
2 times, most recently
from
d9eb61d to
1377dd0
Compare
maflcko
force-pushed
the
2312-std-span-
branch
from
1377dd0 to
6e1b4b1
Compare
Member
Author
Now that it was show that it is possible to compile all code with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::spanallows static extents, which is a nice benefit over justSpan.However, the interface of the two isn't identical and requires some more changes than just defining an alias. This is my current draft to compile with
std::span. This should be the minimal changes required to get a green CI, but the changes may not be ideal, so this remains a draft.Also, this requires and is based on #29071.
In the meantime, changes that make sense on their own, can be split up.