test: check_mempool_result negative feerate#29459
Merged
glozow merged 1 commit intobitcoin:masterfrom Mar 14, 2024
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
maflcko
suggested changes
Feb 21, 2024
Adds test in mempool_accept to check if a negative maxfeerate is inputed into check_mempool_result, asserts "Amount out of range" error message and -3 error code
kevkevinpal
force-pushed
the
mempoolAcceptNegativeValues
branch
from
93e6247 to
bf264e0
Compare
Member
|
lgtm ACK bf264e0 |
Contributor
|
nice, utACK bf264e0 |
Contributor
|
Looks great, ACK bf264e0 If you need to rebase you could also add a check that the same error is thrown when inline bool MoneyRange(const CAmount& nValue) { return (nValue >= 0 && nValue <= MAX_MONEY); }
CAmount AmountFromValue(const UniValue& value, int decimals)
{
// [...]
if (!MoneyRange(amount))
throw JSONRPCError(RPC_TYPE_ERROR, "Amount out of range");
// [...]
}The same tests should probably be added for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test coverage in
mempool_accept.pyto check if a negativemaxfeerateis input intocheck_mempool_resultAsserts "Amount out of range" error message and
-3error codeMotivated by this comment