Rename CalculateHeadersWork to CalculateClaimedHeadersWork#29569
Merged
achow101 merged 1 commit intobitcoin:masterfrom Mar 9, 2024
Merged
Rename CalculateHeadersWork to CalculateClaimedHeadersWork#29569achow101 merged 1 commit intobitcoin:masterfrom
achow101 merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
0xB10C
approved these changes
Mar 6, 2024
| if (prev_block && prev_block->nChainWork + CalculateHeadersWork({pblock->GetBlockHeader()}) >= GetAntiDoSWorkThreshold()) { | ||
| // Check claimed work on this block against our anti-dos thresholds. | ||
| if (prev_block && prev_block->nChainWork + CalculateClaimedHeadersWork({pblock->GetBlockHeader()}) >= GetAntiDoSWorkThreshold()) { | ||
| min_pow_checked = true; |
Contributor
There was a problem hiding this comment.
nit: I also found min_pow_checked confusing. At least I read "PoW checked" at first.
Member
Author
There was a problem hiding this comment.
agreed it's also confusing, but it's also called that down the call stack for a bit, so I kept scope to here
dergoegge
approved these changes
Mar 6, 2024
Member
|
ACK eb7cc9f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And clean up some comments. Confusion about what this is doing seems to be a running theme:
#29549 (comment)
#27278 (comment)