Conversation
The getblockheader RPC with it's true/false verbosity options return the same result as getblock with verbosity 0/1, so it can be cleanly removed.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. |
I don't think that's the case. The following two commands on mainnet return different results: (What is a little confusing though is that the |
|
|
3 participants
The
getblockheaderRPC with its true/false verbosity options returns the same content asgetblockwith verbosity 0/1. So this is an opportunity to remove some code very cleanly, as demonstrated here.I looked for other issues or PRs that suggested this but wasn't successful, obviously let me know if I missed something.
Just looking for conceptual feedback for now. When that is positive I will first run
getblockheaderthrough a depecation cycle. If it is negative I will suggest some deduplication between the two RPCs instead.