test: add missing comparison of node1's mempool in MempoolPackagesTest#29941
test: add missing comparison of node1's mempool in MempoolPackagesTest#29941umiiii wants to merge 0 commit intobitcoin:masterfrom
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. |
glozow
left a comment
glozow
left a comment
There was a problem hiding this comment.
Thanks for the pull, please squash your commits
squashed. |
test/functional/mempool_packages.py
Outdated
There was a problem hiding this comment.
these comments are not needed(and indented wrong); I think they can just all be removed since the test is self-explanatory
There was a problem hiding this comment.
Could you please clarify what you meant by "indented wrong"? I believe these lines are intended to follow the same indentation pattern as the rest of the file. If there's a specific indentation style that should be applied here, I'd appreciate your guidance.
There was a problem hiding this comment.
But I agreed with you. Those lines are self explanatory. I removed the comments.
|
@glozow could you review again and see if it meets the requirements now ..? |
…oolPackagesTest e912717 test: add missing comparison of node1's mempool in MempoolPackagesTest (umiumi) Pull request description: #29941 Recreated a pull request because there was a conflict. Trying to resolve the conflict but the old one automatically closed. Add missing comparison for TODO comments in `mempool_packages.py` Also, notice that the ancestor size limits and descendant size limits actually implemented in #21800 , so I removed the todo for those two size limits. ACKs for top commit: kevkevinpal: ACK [e912717](e912717) achow101: ACK e912717 alfonsoromanz: Tested ACK e912717. The code looks good to me and the test execution is successful. rkrux: tACK [e912717](e912717) Tree-SHA512: 8cb51746b0547369344c9ceef59599bfe9c91d424687af5e24dc6641f9e99fb433515d79c724e71fd3d5e02994f0cef623d3674367b8296b05c3c6fcdde282ef
…in MempoolPackagesTest e912717 test: add missing comparison of node1's mempool in MempoolPackagesTest (umiumi) Pull request description: bitcoin#29941 Recreated a pull request because there was a conflict. Trying to resolve the conflict but the old one automatically closed. Add missing comparison for TODO comments in `mempool_packages.py` Also, notice that the ancestor size limits and descendant size limits actually implemented in bitcoin#21800 , so I removed the todo for those two size limits. ACKs for top commit: kevkevinpal: ACK [e912717](bitcoin@e912717) achow101: ACK e912717 alfonsoromanz: Tested ACK e912717. The code looks good to me and the test execution is successful. rkrux: tACK [e912717](bitcoin@e912717) Tree-SHA512: 8cb51746b0547369344c9ceef59599bfe9c91d424687af5e24dc6641f9e99fb433515d79c724e71fd3d5e02994f0cef623d3674367b8296b05c3c6fcdde282ef
4 participants
Add missing comparison for TODO comments in
mempool_packages.pyAlso, notice that the ancestor size limits and descendant size limits actually implemented in #21800 , so I removed the todo for those two size limits.