Skip to content

rpc: Remove index-based Arg accessor#29997

Merged
achow101 merged 1 commit intobitcoin:masterfrom
maflcko:2404-rpc-no-int-arg-
Jun 5, 2024
Merged

rpc: Remove index-based Arg accessor#29997
achow101 merged 1 commit intobitcoin:masterfrom
maflcko:2404-rpc-no-int-arg-

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Apr 29, 2024

The index-based Arg accessor is redundant with the name-based one. It does not provide any benefit to the code reader, or otherwise, so remove it.

@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 29, 2024 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK stickies-v, ryanofsky, achow101
Concept ACK laanwj

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

No conflicts as of last run.

@maflcko maflcko mentioned this pull request Apr 29, 2024
Merged
@DrahtBot DrahtBot mentioned this pull request Apr 30, 2024
Draft
@laanwj
Copy link
Member

laanwj commented Apr 30, 2024

Concept ACK

ryanofsky
ryanofsky approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@ryanofsky ryanofsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK fadb3eb57b4d207a678067b89caa45abf1f93702

@DrahtBot DrahtBot requested a review from laanwj April 30, 2024 13:46
@maflcko maflcko requested a review from stickies-v May 7, 2024 13:37
stickies-v
stickies-v approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@stickies-v stickies-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fadb3eb57b4d207a678067b89caa45abf1f93702

Can't think of any situations where index-based is preferable over key-based, so this seems like a nice cleanup.

stickies-v
stickies-v reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@stickies-v stickies-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, left my nits on the wrong PR. Nothing blocking, only if you re-touch.

@maflcko maflcko force-pushed the 2404-rpc-no-int-arg- branch from fadb3eb to fa3169b Compare May 15, 2024 15:21
@stickies-v
Copy link
Contributor

stickies-v commented May 15, 2024 •
edited
Loading

re-ACK fa3169b, addressed doc nits

@DrahtBot DrahtBot requested a review from ryanofsky May 15, 2024 16:57
ryanofsky
ryanofsky approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@ryanofsky ryanofsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK fa3169b. One changes since last review are some documentation improvements

@achow101
Copy link
Member

achow101 commented Jun 5, 2024

ACK fa3169b

@achow101 achow101 merged commit 09fe143 into bitcoin:master Jun 5, 2024
@maflcko maflcko deleted the 2404-rpc-no-int-arg- branch June 5, 2024 07:44
@bitcoin bitcoin locked and limited conversation to collaborators Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ryanofsky ryanofsky ryanofsky approved these changes

@laanwj laanwj Awaiting requested review from laanwj

+1 more reviewer

@stickies-v stickies-v stickies-v approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

RPC/REST/ZMQ

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@maflcko @DrahtBot @laanwj @stickies-v @achow101 @ryanofsky