[27.x] Backports and rc1 by fanquake · Pull Request #30092 · bitcoin/bitcoin

fanquake · 2024-05-13T04:22:58Z

Backports:

Bump to 27.1rc1.

Github-Pull: bitcoin-core/gui#812 Rebased-From: 671b7a3

Fixes: bitcoin#809 Previously it was possible through the GUI to enter an IP address:port into the "Proxy IP" configuration box. After the node was restarted the errant setting would prevent the node starting back up until manually removed from settings.json. Github-Pull: bitcoin-core/gui#813 Rebased-From: 10c5275

DrahtBot · 2024-05-13T04:23:01Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	stickies-v, willcl-ark, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Without explicitly declaring the move, these UniValues get copied, causing increased memory usage. Fix this by explicitly moving the UniValue objects. Used by `rest_block` and `getblock` RPC. Github-Pull: bitcoin#30094 Rebased-From: b77bad3

hebasto

ACK 9867e72b995e4a838c8e8e0feb159a9bdee8b76f, I have reproduced backporting locally.

jonatack · 2024-05-14T21:41:47Z

Propose #30085 if merged in time.

Clang is unable to compile the Transform function for that combination of options. Github-Pull: bitcoin#30097 Rebased-From: 141df0a

Addnode (manual) peers connected to us via the cjdns network are currently not detected by CConnman::GetAddedNodeInfo(), i.e. fConnected is always false. This causes the following issues: - RPC `getaddednodeinfo` incorrectly shows them as not connected - CConnman::ThreadOpenAddedConnections() continually retries to connect them Github-Pull: bitcoin#30085 Rebased-From: 684da97

Github-Pull: bitcoin#30085 Rebased-From: d0b0474

The https://miniupnp.tuxfamily.org website is unavailable now. Github-Pull: bitcoin#30151 Rebased-From: 21b8a14

Github-Pull: bitcoin#30149 Rebased-From: 9f4ff1e

willcl-ark

ACK cb6def3855427b613357696ba16a431c7964dbcc

Reviewed that all backports were unmodified, and that associated PR #'s match.

Lightly reviewed release notes and manpage and they look good to me.

stickies-v

ACK cb6def3855427b613357696ba16a431c7964dbcc modulo small release notes fix

All backport commits are clean, except for:

77b2321 backported from 21b8a14: version bumped in #29707 - LGTM

No diff with my local manpage generation.

stickies-v · 2024-05-24T13:17:01Z

doc/release-notes.md

Suggested change

Bitcoin Core version 27.1 is now available from:

<https://bitcoincore.org/bin/bitcoin-core-27.1/>

Bitcoin Core version 27.1rc1 is now available from:

<https://bitcoincore.org/bin/bitcoin-core-27.1/test.rc1/>

nit but text is not updated to "271.rc1" in latest force push (link is fine now)

hebasto

ACK cb6def3855427b613357696ba16a431c7964dbcc.

Feel free to update translations with python3 ../bitcoin-maintainer-tools/update-translations.py or cherry-pick the hebasto@c9c42cc commit.

hebasto

re-ACK f30e23e4b35b52728ebaa1a63ec9a6feac51ebb4,

willcl-ark

reACK f30e23e4b35b52728ebaa1a63ec9a6feac51ebb4

Didn't review the newly-added individual translations, but apart from that changes LGTM.

stickies-v

re-ACK f30e23e4b35b52728ebaa1a63ec9a6feac51ebb4, I'm getting the same translation update results as in 80032d6

stickies-v · 2024-05-28T10:30:54Z

doc/release-notes.md

nit but text is not updated to "271.rc1" in latest force push (link is fine now)

stickies-v · 2024-05-28T17:47:27Z

re-ACK 22701a4

willcl-ark · 2024-05-29T07:52:46Z

reACK 22701a4

on range-diff https://github.com/bitcoin/bitcoin/compare/f30e23e4b35b52728ebaa1a63ec9a6feac51ebb4..22701a43464ab27ea83c8b49e2732ee647909a10

hebasto

re-ACK 22701a4.

furszy and others added 2 commits May 13, 2024 11:57

gui: fix create unsigned transaction fee bump

d1289a1

Github-Pull: bitcoin-core/gui#812 Rebased-From: 671b7a3

fanquake added this to the 27.1 milestone May 13, 2024

DrahtBot added the Backport label May 13, 2024

This was referenced May 13, 2024

Don't permit port in proxy IP option bitcoin-core/gui#813

Merged

Fix create unsigned transaction fee bump bitcoin-core/gui#812

Merged

DrahtBot added the CI failed label May 13, 2024

rpc: move UniValue in blockToJSON

0ba11cf

Without explicitly declaring the move, these UniValues get copied, causing increased memory usage. Fix this by explicitly moving the UniValue objects. Used by `rest_block` and `getblock` RPC. Github-Pull: bitcoin#30094 Rebased-From: b77bad3

fanquake force-pushed the 27_1_rel_prep branch from 7c75bc0 to 9867e72 Compare May 14, 2024 00:16

fanquake mentioned this pull request May 14, 2024

rpc: move UniValue in blockToJSON #30094

Merged

DrahtBot removed the CI failed label May 14, 2024

hebasto approved these changes May 14, 2024

View reviewed changes

crypto: disable asan for sha256_sse4 with clang and -O0

3c26058

Clang is unable to compile the Transform function for that combination of options. Github-Pull: bitcoin#30097 Rebased-From: 141df0a

fanquake force-pushed the 27_1_rel_prep branch from 9867e72 to 1927f8b Compare May 16, 2024 00:43

fanquake mentioned this pull request May 16, 2024

crypto: disable asan for sha256_sse4 with clang and -O0 #30097

Merged

fanquake force-pushed the 27_1_rel_prep branch from 1927f8b to 116ef31 Compare May 22, 2024 09:38

fanquake mentioned this pull request May 22, 2024

p2p: detect addnode cjdns peers in GetAddedNodeInfo() #30085

Merged

fanquake marked this pull request as ready for review May 22, 2024 10:00

fanquake changed the title ~~[27.x] Backports and probably finalize~~ [27.x] Backports and rc1 May 22, 2024

jonatack and others added 2 commits May 23, 2024 09:44

test: add GetAddedNodeInfo() CJDNS regression unit test

31adcfa

Github-Pull: bitcoin#30085 Rebased-From: d0b0474

depends: Fetch miniupnpc sources from an alternative website

77b2321

The https://miniupnp.tuxfamily.org website is unavailable now. Github-Pull: bitcoin#30151 Rebased-From: 21b8a14

fanquake force-pushed the 27_1_rel_prep branch from 116ef31 to 37d9938 Compare May 23, 2024 08:45

fanquake mentioned this pull request May 23, 2024

depends: Fetch miniupnpc sources from an alternative website #30151

Merged

windeploy: Renew certificate

423bd6d

Github-Pull: bitcoin#30149 Rebased-From: 9f4ff1e

fanquake force-pushed the 27_1_rel_prep branch from 37d9938 to cb6def3 Compare May 23, 2024 12:30

fanquake mentioned this pull request May 23, 2024

contrib: Renew Windows code signing certificate #30149

Merged

fanquake requested a review from stickies-v May 24, 2024 10:31

fanquake requested a review from willcl-ark May 24, 2024 10:31

willcl-ark approved these changes May 24, 2024

View reviewed changes

DrahtBot requested a review from hebasto May 24, 2024 11:52

stickies-v reviewed May 24, 2024

View reviewed changes

hebasto approved these changes May 27, 2024

View reviewed changes

qt: 27.1rc1 translations update

80032d6

fanquake force-pushed the 27_1_rel_prep branch from cb6def3 to f30e23e Compare May 28, 2024 09:23

hebasto approved these changes May 28, 2024

View reviewed changes

DrahtBot requested review from stickies-v and willcl-ark May 28, 2024 09:44

willcl-ark approved these changes May 28, 2024

View reviewed changes

stickies-v approved these changes May 28, 2024

View reviewed changes

fanquake added 3 commits May 28, 2024 12:28

doc: update release-notes.md for 27.1

9b4640c

build: bump version to 27.1rc1

9e91907

doc: update manual pages for 27.1rc1

22701a4

fanquake force-pushed the 27_1_rel_prep branch from f30e23e to 22701a4 Compare May 28, 2024 11:28

DrahtBot requested review from hebasto and willcl-ark May 28, 2024 17:47

hebasto approved these changes May 29, 2024

View reviewed changes

fanquake merged commit fccd32e into bitcoin:27.x May 29, 2024

fanquake deleted the 27_1_rel_prep branch May 29, 2024 08:27

bitcoin locked and limited conversation to collaborators May 29, 2025

-Bitcoin Core version 27.1 is now available from:
-  <https://bitcoincore.org/bin/bitcoin-core-27.1/>
+Bitcoin Core version 27.1rc1 is now available from:
+  <https://bitcoincore.org/bin/bitcoin-core-27.1/test.rc1/>

Conversation

fanquake commented May 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented May 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage

Reviews

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

jonatack commented May 14, 2024

Uh oh!

willcl-ark left a comment

Choose a reason for hiding this comment

Uh oh!

stickies-v left a comment

Choose a reason for hiding this comment

Uh oh!

stickies-v May 24, 2024

Choose a reason for hiding this comment

Uh oh!

stickies-v May 28, 2024

Choose a reason for hiding this comment

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

willcl-ark left a comment

Choose a reason for hiding this comment

Uh oh!

stickies-v left a comment

Choose a reason for hiding this comment

Uh oh!

stickies-v May 28, 2024

Choose a reason for hiding this comment

Uh oh!

stickies-v commented May 28, 2024

Uh oh!

willcl-ark commented May 29, 2024

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

fanquake commented May 13, 2024 •

edited

Loading

DrahtBot commented May 13, 2024 •

edited

Loading