doc: use TRUC instead of v3 and add release note#30272
doc: use TRUC instead of v3 and add release note#30272achow101 merged 6 commits intobitcoin:masterfrom
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
glozow
force-pushed
the
2024-06-v3-followups
branch
from
ca42354 to
ce007e8
Compare
glozow
force-pushed
the
2024-06-v3-followups
branch
from
ce007e8 to
a6821a0
Compare
|
Concept ACK 🚜 |
instagibbs
left a comment
instagibbs
left a comment
There was a problem hiding this comment.
ACK a6821a0a4e1cf2aba679962289f4beeefd3d539a
fairly mechanical changes
doc/release-notes-29496.md
Outdated
There was a problem hiding this comment.
could directly link the BIP here: https://github.com/bitcoin/bips/blob/master/bip-0431.mediawiki
|
cc @murchandamus @ismaelsadeeq since you suggested the doc changes |
test/functional/mempool_accept_v3.py
Outdated
There was a problem hiding this comment.
Maybe update test/functional/wallet_create_tx.py test.
see d3fa531, if it makes sense feel free to cherry-pick
Keep mentions of v3 in debug strings to help people who might not know that TRUC is applied when version=3. Also keep variable names in tests, as it is less verbose to keep v3 and v2.
-BEGIN VERIFY SCRIPT- sed -i 's/SingleV3Checks/SingleTRUCChecks/g' $(git grep -l 'SingleV3Checks') sed -i 's/PackageV3Checks/PackageTRUCChecks/g' $(git grep -l 'PackageV3Checks') sed -i 's/PV3C/PTRUCC/g' src/policy/truc_policy.h sed -i 's/V3_MAX_VSIZE/TRUC_MAX_VSIZE/g' $(git grep -l 'V3_MAX_VSIZE') sed -i 's/V3_CHILD_MAX_VSIZE/TRUC_CHILD_MAX_VSIZE/g' $(git grep -l 'V3_CHILD_MAX_VSIZE') sed -i 's/V3_DESCENDANT_LIMIT/TRUC_DESCENDANT_LIMIT/g' $(git grep -l 'V3_DESCENDANT_LIMIT') sed -i 's/V3_ANCESTOR_LIMIT/TRUC_ANCESTOR_LIMIT/g' $(git grep -l 'V3_ANCESTOR_LIMIT') sed -i 's/CheckMempoolV3Invariants/CheckMempoolTRUCInvariants/g' $(git grep -l 'CheckMempoolV3Invariants') -END VERIFY SCRIPT-
glozow
force-pushed
the
2024-06-v3-followups
branch
from
a6821a0 to
4664f50
Compare
glozow
left a comment
glozow
left a comment
There was a problem hiding this comment.
thanks @ismaelsadeeq! Took your suggestions and fixed docs in a few more places
Make it more clear to the user what we mean by v3.
glozow
force-pushed
the
2024-06-v3-followups
branch
from
4664f50 to
926b8e3
Compare
|
reACK 926b8e3 reviewed via "git range-diff master a6821a0 926b8e3" |
|
ACK 926b8e3 |
|
Ported to the CMake-based build system in hebasto#264. |
7 participants
Adds a release note for TRUC policy which will be live in v28.0.
For clarity, replaces mentions of "v3" with "TRUC" in most places. Suggested in
I changed error strings from "v3-violation" to "TRUC-violation" but left v3 in the debug strings because I think it might be clearer for somebody who is debugging. Similarly, I left some variables unchanged because I think they're more descriptive this way, e.g.
tx_v3_from_v2_and_v3. I'm happy to debate places that should or shouldn't be documented differently in this PR, whatever is clearest to everyone.