net: Clarify that m_addr_local is only set once#30617
Merged
glozow merged 1 commit intobitcoin:masterfrom Aug 13, 2024
Merged
Conversation
Includes a rename from addrLocal to m_addr_local to match the name of its corresponding Mutex.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
|
ACK fa6fe43 |
mzumsande
reviewed
Aug 12, 2024
Member
Author
|
Just to clarify: This should be a refactor (no behavior change for |
glozow
reviewed
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function is supposed to be only called once when the version msg arrives (a single time). Calling it twice would be an internal logic bug. However, the
LogErrorin this function has many issues:Fix all issues by using
Assume(!m_addr_local.IsValid())instead. Idea taken from #30364 (comment)