The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #30595 (kernel: Introduce initial C header API by TheCharlatan)
• #29852 ([WIP] build: remove need to test for endianness by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

🚧 At least one of the CI tasks failed.
_{Debug: https://github.com/bitcoin/bitcoin/runs/30150430662}

A few things still need to be addressed:

This PR is also changing the flags used for code generation. Is that intentional? If yes, would be good to mention in the PR description (and why).

This PR is also changing the flags used for code generation.

Yes. The crc32c upstream build system modifies flags in many places, for example:

  # Disable C++ exceptions.
  string(REGEX REPLACE "-fexceptions" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-exceptions")


  # Disable RTTI.
  string(REGEX REPLACE "-frtti" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-rtti")

Is that intentional?

The intention isn't mine.

Ok. Well the current changes would be unsafe to merge, and I don't think we should be adjusting our build system to work around the subtree, if anything, we should just change the subtree directly.

Closing, as the consensus between myself, @hebasto, @theuni and @TheCharlatan was to not make this change (for now, or not until we've adjusted upstream further).