torcontrol: Add comment explaining Proxy credential randomization for Tor privacy#31973
torcontrol: Add comment explaining Proxy credential randomization for Tor privacy#31973eval-exec wants to merge 1 commit intobitcoin:masterfrom
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31973. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
eval-exec
force-pushed
the
exec/comment-onion-random-credential
branch
from
7f7bdcc to
88ee6c5
Compare
src/torcontrol.cpp
Outdated
There was a problem hiding this comment.
Yes-FWIW, the main way in which this increases privacy is that every new connection is likely to choose a different exit node, so will appear to come from a different host.
There's something to be said for adding this documentation for the Proxy constructor, but as this specific behavior is specific to Tor (and not SOCKS5 in general) i have no objection to adding it here.
… Tor privacy Signed-off-by: Eval EXEC <[email protected]>
eval-exec
force-pushed
the
exec/comment-onion-random-credential
branch
from
88ee6c5 to
65e503e
Compare
|
🚧 At least one of the CI tasks failed. HintsTry to run the tests locally, according to the documentation. However, a CI failure may still
Leave a comment here, if you need help tracking down a confusing failure. |
This comment was marked as abuse.
This comment was marked as abuse.
|
Friendly ping @fanquake , I think this PR is ready to be merged. |
|
Has cherry-pick this commit into #32166 |
…ur maintainability 8e4a0dd torcontrol: Add comment explaining Proxy credential randomization for Tor privacy (Eval EXEC) ec5c0b2 torcontrol: Define tor reply code as const to improve maintainability (Eval EXEC) Pull request description: This PR want to: 1. replace tor repy code with const to improve out maintainability. 2. cherry-picked #31973 , add comment to explain Proxy credential randomization for Tor privacy ACKs for top commit: hodlinator: re-ACK 8e4a0dd laanwj: re-ACK 8e4a0dd Tree-SHA512: 038daa6508ca88fceed5c8e155430614cb56976f36d1f8baee5114bca1141122cf94f51814a869848b3442691ee765cbf609cf946b2b35d5135015a9b749d917
4 participants
When I reviewing bitcoin's torcontrol.cpp's source code, the
truein:bitcoin/src/torcontrol.cpp
Line 400 in 79bbb38
is not easy to understand, so I add a comment to help us read that. Friendly invite @luke-jr to review this.