Sanitize assert usage and refuse to compile with NDEBUG.#3344
Merged
gavinandresen merged 1 commit intobitcoin:masterfrom Dec 3, 2013
gmaxwell:assert_hazards
Merged
Sanitize assert usage and refuse to compile with NDEBUG.#3344gavinandresen merged 1 commit intobitcoin:masterfrom gmaxwell:assert_hazards
gavinandresen merged 1 commit intobitcoin:masterfrom
gmaxwell:assert_hazards
Conversation
There were quite a few places where assert() was used with side effects, making operation with NDEBUG non-functional. This commit fixes all the cases I know about, but also adds an #error on NDEBUG because the code is untested without assertions and may still have vulnerabilities if used without assert.
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/9b59e3bda8c137bff885db5b1f9150346e36e076 for binaries and test log. |
Contributor
|
ACK. Merging because it is obviously better. |
gavinandresen
added a commit
that referenced
this pull request
Dec 3, 2013
Sanitize assert usage and refuse to compile with NDEBUG.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were quite a few places where assert() was used with side effects,
making operation with NDEBUG non-functional. This commit fixes all the
cases I know about, but also adds an #error on NDEBUG because the code
is untested without assertions and may still have vulnerabilities if
used without assert.