Merged
Conversation
Github-Pull: bitcoin#34252 Rebased-From: 44b12cd
The previous `assert` used `>=`, allowing `input_index == psbt.inputs.size()` and out-of-bounds access in `psbt.inputs[input_index]`. Found during review: bitcoin#31650 (comment) Github-Pull: bitcoin#34272 Rebased-From: 2f5b1c5
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34283. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
This was referenced Jan 14, 2026
Github-Pull: bitcoin#34185 Rebased-From: 9b57c8d
Github-Pull: bitcoin#34185 Rebased-From: 8fb5e5f
fanquake
force-pushed
the
30_3_backports
branch
from
09cf8be to
0b11d7a
Compare
The regex `(.*)` was capturing `\r` from subprocess output on Windows, causing the closing parenthesis in logs to wrap to the next line. Stripping whitespace from the regex match fixes the formatting. Github-Pull: bitcoin#34282 Rebased-From: 979d41b
fanquake
force-pushed
the
30_3_backports
branch
from
0b11d7a to
d2ecf8c
Compare
Github-Pull: bitcoin#34344 Rebased-From: 9482f00
fanquake
force-pushed
the
30_3_backports
branch
from
d2ecf8c to
12e75fc
Compare
Facilitate use on distros that might have 'tar' as something else, such as 'gtar', i.e Chimera. Github-Pull: bitcoin#34390 Rebased-From: be2b48b
fanquake
force-pushed
the
30_3_backports
branch
from
12e75fc to
6ab1db8
Compare
Github-Pull: bitcoin#34281 Rebased-From: fa37928
fanquake
force-pushed
the
30_3_backports
branch
from
6ab1db8 to
725e6ee
Compare
This was referenced Jan 27, 2026
added 2 commits
January 28, 2026 14:24
The section claims to be for ccache builds, however those are already fixed after commit 1cc58d3. If there are still any build or debug problems after that commit, dedicated instructions can be added back, along with exact steps to reproduce and test. Github-Pull: bitcoin#34413 Rebased-From: fa06cd4
The -ffile-prefix-map option is no longer used and it seems fine to remove the warning about it possibly breaking coverage builds. If this needs documentation, the dev notes seem like a better place, because it also affects other places, such as depends. C.f. commit 407062f Github-Pull: bitcoin#34413 Rebased-From: fa2e1b8
fanquake
force-pushed
the
30_3_backports
branch
from
725e6ee to
8dbdec1
Compare
removeprunedfunds removes all entries from mapTxSpends for the inputs of the pruned tx. However, this is incorrect, because there could be multiple entries from conflicting transactions (that shouldn't be removed as well). This could lead to the wallet creating invalid transactions, trying to double spend utxos. The bug persists when the conflicting tx was mined, because the wallet trusts its internal accounting instead of calling AddToSpends again. Github-Pull: bitcoin#34358 Rebased-From: 1f60ca3
fanquake
force-pushed
the
30_3_backports
branch
from
8dbdec1 to
836adc0
Compare
We can use vswhere.exe directly to create a vs developer prompt and so can remove this third party dependency. Co-authored-by: David Gumberg <[email protected]> Github-Pull: bitcoin#32513 Rebased-From: 7ae0497
This sets up a vs developer command prompt and should hopefully should be more resilient to upstream changes Co-authored-by: David Gumberg <[email protected]> Github-Pull: bitcoin#32513 Rebased-From: e1a1b14
The other executables have manifests and these should be checked in addition to bitcoind. Skipping fuzz.exe, bench_bitcoin.exe and test_bitcoin-qt.exe as they do not have manifests. Github-Pull: bitcoin#32513 Rebased-From: 1569279
fanquake
force-pushed
the
30_3_backports
branch
from
836adc0 to
624c745
Compare
willcl-ark
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports:
feature_pruningwhen built without wallet #34185PSBTInputSignedAndVerifiedboundsassert#34272-fdebug-prefix-map#34281taringet_previous_releases.py#34390