Bugfix: GUI/Intro: Handle errors from SelectParams the same as if during InitConfig#34767
Open
luke-jr wants to merge 1 commit intobitcoin:masterfrom
Open
Bugfix: GUI/Intro: Handle errors from SelectParams the same as if during InitConfig#34767luke-jr wants to merge 1 commit intobitcoin:masterfrom
luke-jr wants to merge 1 commit intobitcoin:masterfrom
Conversation
…ing InitConfig Without this, invalid vbparams just silently exit with no message
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
|
cc @hebasto |
Contributor
|
@luke-jr Can you give some guidance on how to reproduce the issue this fixes and/or a test case? |
Member
Author
|
Just start bitcoin-qt with -regtest -vbparams and some out of range numbers |
Member
|
Is this being moved to the GUI repo? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, invalid vbparams just silently exit with no message