doc: update http worker thread names#34769
Merged
sedited merged 1 commit intobitcoin:masterfrom Mar 10, 2026
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
Contributor
|
I think it should stay |
l0rinc
approved these changes
Mar 7, 2026
Contributor
Author
Do you mean updating their Doxygen links? |
After using `Threadpool` for HTTP server in PR 33689, the previously documented HTTP worker thread names are outdated. This commit makes the corresponding changes to document new names for the HTTP worker threads. Below is the output from the `thead list` command after attaching `lldb` to `bitcoind`. ```zsh thread bitcoin#3: tid = 0xfe551, 0x00007ff80e3536f6 libsystem_kernel.dylib`__psynch_cvwait + 10, name = 'b-http_pool_0' thread bitcoin#4: tid = 0xfe552, 0x00007ff80e3536f6 libsystem_kernel.dylib`__psynch_cvwait + 10, name = 'b-http_pool_1' ```
rkrux
changed the title
Member
|
cc @furszy |
Contributor
|
ACK 46189fd |
hebasto
approved these changes
Mar 10, 2026
| : Libevent thread to listen for RPC and REST connections. | ||
|
|
||
| - [HTTP worker threads(`b-httpworker.x`)](https://doxygen.bitcoincore.org/httpserver_8cpp.html#aa6a7bc27265043bc0193220c5ae3a55f) | ||
| - [HTTP worker threads (`b-http_pool_x`)](https://doxygen.bitcoincore.org/httpserver_8cpp.html#a2ad0a49dc9b5e8117c0dee98c24187d8) |
theStack
approved these changes
Mar 10, 2026
furszy
reviewed
Mar 10, 2026
sedited
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After using
Threadpoolfor HTTP server in PR 33689, the previouslydocumented HTTP worker thread names are outdated. This commit makes
the corresponding changes to document new names for the HTTP worker
threads. Below is the output from the
thead listcommand afterattaching
lldbtobitcoind.