qt: Move AppInit2 and Shutdown to a thread#3493
Merged
laanwj merged 4 commits intobitcoin:masterfrom Jan 11, 2014
Merged
Conversation
Member
Author
|
Testing in #1242 confirms that the Ubuntu menu+icon issue is solved by these changes. |
Move AppInit2 and Shutdown to a thread. This allows a more responsive splash screen, prevents 'process does not respond' messages from the window system and will allow for showing a user friendly window while shutting down.
Makes it clear to the user that the application is still wrapping up and the computer should not be turned off until it is finished.
Remove the need for global references `guiref` and `splashref` by making the BitcoinGUI and SplashScreen classes register for the UI interface signals themselves.
Stop the shutdown timer from exiting the main loop when shutdown is already in progress. Fixes seeming hanging window after typing 'stop' in debug console. Also hide the debug console during shutdown as it is useless without a core to connect to.
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/9a2305a1b3075d110f4127a3d3c38b014237968a for binaries and test log. |
laanwj
added a commit
that referenced
this pull request
Jan 11, 2014
9a2305a qt: Stop shutdown detection timer during shutdown (Wladimir J. van der Laan) 35ecf85 qt: Remove global references in bitcoin.cpp (Wladimir J. van der Laan) 55fe4de qt: Show window while shutting down (Wladimir J. van der Laan) 202d853 qt: Move initialization/shutdown to a thread (Wladimir J. van der Laan)
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run initialization and shutdown in their own thread instead of the UI thread.
Process does not respondmessages from the window system while initializing (common complaint)Bitcoin Core is shutting down...window while shutting downHopefullyfixes Ubuntu issue Bitcoin-Qt 0.6.2 for Ubuntu 12.04 invisible in systray, no global menu #1242 preventing the menu and icon from appearing