Avoid using CBigNum for simple multiplications#3517
Closed
sipa wants to merge 1 commit intobitcoin:masterfrom
Closed
Avoid using CBigNum for simple multiplications#3517sipa wants to merge 1 commit intobitcoin:masterfrom
sipa wants to merge 1 commit intobitcoin:masterfrom
Conversation
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/87aacaa633bfedaf9947e051dee47807bdeaff9b for binaries and test log. |
Member
|
ACK |
Member
Author
|
I completely forgot I wrote this. It's superceded by #4076 now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a simple multiplication operator in uint256, and use it for the few cases where we used to convert to CBigNum for this.
Tests are included that verify the behavior is identical to converting to CBigNum, doing the multiplication, and converting back.
Overall goal: reduce dependency on OpenSSL where possible in core code.