Add RPC command listtransactionsaftertime#355
Closed
pixelglow wants to merge 1 commit intobitcoin:masterfrom
Closed
Add RPC command listtransactionsaftertime#355pixelglow wants to merge 1 commit intobitcoin:masterfrom
pixelglow wants to merge 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
See #199 I like the other pull's approach better because times in bitcoin are fuzzy-- transactions take on the time of the block that they're included in, and will change as block-chain re-orgs happen. |
Author
|
How do we know which transactions belong in which block, in order for us to call listsinceblock with the correct block? |
Author
|
Ah ok, he's returning the block id as well. When are you integrating this? |
Contributor
|
Consensus seems to be pull 199 is a better approach. I'm going to close this. |
ptschip
pushed a commit
to ptschip/bitcoin
that referenced
this pull request
Mar 11, 2017
[Doc] Improve Tor documentation
classesjack
pushed a commit
to classesjack/bitcoin
that referenced
this pull request
Jan 2, 2018
Neil/pertxout
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Oct 16, 2019
Patch 2 (README Names of Coin)
Losangelosgenetics
pushed a commit
to Losangelosgenetics/bitcoin
that referenced
this pull request
Mar 12, 2020
, closes bitcoin#406, closes bitcoin#355, closes bitcoin#305)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a process is polling bitcoind for new transactions, the existing RPC command listtransactions is not adequate. In particular, since there's no way for listtransactions to report all transaction AFTER a certain point in time, the polling process will necessarily have to grab more and more transactions and sort through them, or risk missing transactions if it uses a limit that's too small.
This new command listtransactionsaftertime solves the issue.
In particular, you use listtransactionsaftertime to get all transactions after a particular time (as timestamped on all transactions). A typical polling process can then grab all transactions after the last seen transaction time and be guaranteed a complete transaction log.