Conversation
Because it is a wallet option. If you think it should be hidden as a debugging option put it behind the |
|
ACK. Good catch on the dPriorityNeeded = -1 bug. I could quibble with the CFeeRate::GetFee() change (you cannot set a voluntary fee rate less than the hard-coded minRelayTxFee), but the code change is fine belt-and-suspenders. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4465_d88af560111863c3e9c1ae855dcc287f04dffb02/ for binaries and test log. |
|
update:
|
so we always "break;"
For example, if you set the voluntary fee to 1 satoshi, and the tx has less than 1000 bytes,
payTxFee.GetFee(nTxBytes) returns zero, this results in CWallet::GetMinimumFee(..) to return
pool.estimateFee(..) instead of the voluntary fee. So its not possible to set the voluntary fee as low as 1 satoshi.
dPriority >= dPriorityNeeded, even in the voluntary fee case. And we need to consider, that
CreateTransaction pays at least for 1000 bytes in the voluntary fee case.
Just a question, why did -mintxfee move from Testing options to Wallet options?
I dont think we should bother people with this, otherwise we wouldnt need smart fee in the first place.