Optimization: only keep setBlockIndexValid entries that are possible improvements#4497
Merged
sipa merged 1 commit intobitcoin:masterfrom Jul 30, 2014
Merged
Optimization: only keep setBlockIndexValid entries that are possible improvements#4497sipa merged 1 commit intobitcoin:masterfrom
sipa merged 1 commit intobitcoin:masterfrom
Conversation
Member
Author
|
Thanks @BitcoinPullTester, fixed a bug. |
Member
Author
|
Added some comments and an assert. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4497_714a3e6505d986d064d3a34038a724ac1cad5308/ for binaries and test log. |
Member
|
Tested ACK (ran on test node for two weeks without problems) |
Contributor
|
ut ACK |
sipa
added a commit
that referenced
this pull request
Jul 30, 2014
714a3e6 Only keep setBlockIndexValid entries that are possible improvements (Pieter Wuille)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, we kept all valid CBlockIndex* entries in setBlockInvalidValid, but as it is only used to select potential new tips to activate, it suffices to only keep entries that are at least as good as the current tip.
This should save some memory in the stable synced state: 13 MiB on 64 bit, 8 MiB on 32 bit.