Conversation
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4614_0adf98ed38c706ebae07a0d74bf6bab18e1b9f42/ for binaries and test log. |
|
I updated the original PR. |
|
ACK |
|
ACK. I like this, I generally prefer more specific typing. |
|
Why the change to pass by const ref? For something that small you'll likely get better codegen just passing by value. |
|
@bpay As long as CAmount is a simple type, yes. |
|
Jorge, there's a number of locations in this pull request using int64 which have not been updated to use the new type. (Compare diffs with #4234, which is now properly rebased & updated.) |
|
Let's just merge #4234 then, I'm closing this one. |
Rebased and bike-shed version of #4234