Remove unnecessary dependencies in script.cpp#4674
Remove unnecessary dependencies in script.cpp#4674jtimon wants to merge 1 commit intobitcoin:masterfrom
Conversation
|
Several of the local includes are quite obviously used in script, such as crypto. NAK as-is. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4674_54f048158b1b9864b5119c5f7dc3f126182288c0/ for binaries and test log. |
|
Those are included in hash, which is included in key, which is included in keystore. |
|
You always want to include all direct dependencies of a file. Doing so As a general rule, an indirect dependency should not hide a direct |
|
Using an #include says "I am using this API" It does not matter if other headers also use that API; you cannot depend on that fact, as indirect dependencies may change. This change makes the build more fragile and misunderstands how standard C/C++ header inclusion works. |
Cleaning up includes that don't seem necessary anymore.