Remove CScriptCheck::nHashType (was always 0)#4775
Remove CScriptCheck::nHashType (was always 0)#4775jtimon wants to merge 2 commits intobitcoin:masterfrom
Conversation
|
Needs rebase, but ut ACK. |
|
Agree on removing the VerifySignature function that is only used by the tests. NACK on partially removing CScriptCheck::nHashType. Either it should be removed completely and this removal propagated through VerifyScript, or it would be better to keep it like this. Mind that |
|
Oh, that's what you do in #4555, well then it's fine with me. |
|
Rebased |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4775_5ad29370edc22558539bd89135c02d3de4c7bc52/ for binaries and test log. |
|
ut ACK. |
It's only used in one place and CScriptCheck can be used directly instead.
Also remove CScriptCheck::nHashType since was always 0.
In preparation of #4555