Move checkpoint data selection to chainparams#4801
Closed
jtimon wants to merge 2 commits intobitcoin:masterfrom
Closed
Move checkpoint data selection to chainparams#4801jtimon wants to merge 2 commits intobitcoin:masterfrom
jtimon wants to merge 2 commits intobitcoin:masterfrom
Conversation
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4801_0781bde927f8cbf55693eb63ef4c6ac96886d49f/ for binaries and test log. |
This was referenced Aug 31, 2014
Contributor
Author
|
Included in #4802, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we avoid the calls to Params().NetworkID() in checkpoints.cpp.
If at some point we're going to read the chainparams from data files, we probably want to put the checkpoint data there as well