Only need to subtract 1 (originally time was in seconds).#4828
Only need to subtract 1 (originally time was in seconds).#4828rebroad wants to merge 1 commit intobitcoin:masterfrom
Conversation
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4828_469f440924f120f34c6e065d236e8ca230456445/ for binaries and test log. |
|
Can you also add a comment to explain why the -1 is there to begin with? |
|
@TheBlueMatt I used to understand why the -1 was there long ago, but I've lost the memory of why it was needed now... I'd have to relook at the code from years ago to work it out. |
|
Closing in favor of #4831 which does away with this voodoo. |
4 participants
#3514 changed the time used with askfors from seconds to milliseconds but the change introduced an assumption that the time needed to be reduced by 1 second, when it fact it was the number that needed to be reduced by 1.