qt: Change splash screen to normal window#4941
Conversation
Makes it possible to move, minimize, unminimize the window while Bitcoin Core is initializing.
laanwj
force-pushed
the
2014_09_splashscreen_normal
branch
from
639b2dc to
a49f11d
Compare
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4941_a49f11d9edf2f7dbce154ca370494a8f86e013d0/ for binaries and test log. |
|
Works for me. (linux qt4 and qt5) |
|
works as intended on osx. |
a49f11d qt: Change splash screen to normal window (Wladimir J. van der Laan)
|
Just after merging I realize that this makes it possible to close (using the corner X) the splash screen. The same is possible for the window shown on shutdown. This is not harmful in itself, but does still create a way to close the window without a way to bring it back. Probably should be disallowed at some point. |
There was a problem hiding this comment.
We paint the entire background so it should not be necessary
Summary: Cleaning up after replacing the QSplashScreen base class with the QWidget class ([[bitcoin/bitcoin#4941 | PR4941]]). Backport of Core [[bitcoin/bitcoin#14854 | PR14854]] Test Plan: ``` ninja && ninja check src/qt/bitcoin-qt ``` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D7840
6 participants
Makes it possible to move, minimize, unminimize the window while Bitcoin Core is initializing.
Fixes: any splash-screen related issue ever; at least #4915 #4644