Make -proxy set all network types, avoiding a connect leak.#5358
Merged
laanwj merged 1 commit intobitcoin:masterfrom Nov 24, 2014
gmaxwell:proxyallnet
Merged
Make -proxy set all network types, avoiding a connect leak.#5358laanwj merged 1 commit intobitcoin:masterfrom gmaxwell:proxyallnet
laanwj merged 1 commit intobitcoin:masterfrom
gmaxwell:proxyallnet
Conversation
Previously -proxy was not setting the proxy for IsLimited networks, so if you set your configuration to be onlynet=tor you wouldn't get an IPv4 proxy set. The payment protocol gets its proxy configuration from the IPv4 proxy, and so it would experience a connection leak. This addresses issue #5355 and also clears up a cosmetic bug where getinfo proxy output shows nothing when onlynet=tor is set.
Member
|
Ouch ouch ouch. Good catch. Ideally the payment request code wouldn't even try connecting over IPv4 if the network is limited, but better to err on the safe side. |
Member
|
Needs backport to 0.9.x too. |
Member
|
utACK |
Contributor
|
ut ACK |
laanwj
added a commit
that referenced
this pull request
Nov 24, 2014
3c77714 Make -proxy set all network types, avoiding a connect leak. (Gregory Maxwell)
gmaxwell
added a commit
that referenced
this pull request
Nov 24, 2014
Previously -proxy was not setting the proxy for IsLimited networks, so if you set your configuration to be onlynet=tor you wouldn't get an IPv4 proxy set. The payment protocol gets its proxy configuration from the IPv4 proxy, and so it would experience a connection leak. This addresses issue #5355 and also clears up a cosmetic bug where getinfo proxy output shows nothing when onlynet=tor is set. Conflicts: src/init.cpp Rebased-From: 3c77714 Github-Issue: #5358
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously -proxy was not setting the proxy for IsLimited networks, so
if you set your configuration to be onlynet=tor you wouldn't get an
IPv4 proxy set.
The payment protocol gets its proxy configuration from the IPv4 proxy,
and so it would experience a connection leak.
This addresses issue #5355 and also clears up a cosmetic bug where
getinfo proxy output shows nothing when onlynet=tor is set.