TRIVIAL: Refactor: inline CTxIn::IsFinal() [ only used in main::IsFinalTx() ]#5769
Closed
jtimon wants to merge 1 commit intobitcoin:masterfrom
Closed
TRIVIAL: Refactor: inline CTxIn::IsFinal() [ only used in main::IsFinalTx() ]#5769jtimon wants to merge 1 commit intobitcoin:masterfrom
jtimon wants to merge 1 commit intobitcoin:masterfrom
Conversation
Member
|
NACK. It's less lines, but less self-documenting. Semantic information as well as encapsulation is lost |
Contributor
Author
|
Another argument is moving more logic out of the primitives, the same reason why @sipa didn't wanted primitives/block to depend on pow.o |
Member
|
@laanwj Would making a IsTxInFinal function in main be acceptable? |
Contributor
Author
|
I think at that point actual documentation would be better than self-documentation. |
jtimon
referenced
this pull request
in maaku/bitcoin
May 16, 2015
…hose semantics will not survive revival of sequence numbers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Less lines.